Issue 688: UDP packet has timestamp field #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats. |
baranovmv
changed the title
gavv
reviewed
May 7, 2024
Comment on lines
248
to
249
|
|
||
| packet->udp()->enqueue_ts = core::timestamp(core::ClockUnix); | ||
| return packet_router_->write(packet); |
There was a problem hiding this comment.
-
Maybe move this into packet::Router::write? Packet router is supposed to be entry point to the packets pipeline, so it looks like a good place to be responsible for filling timestamps. On the other hand, it would be nice to keep pipeline more high-level.
-
We need a guard for the case when packet->udp() returns NULL. (I think we can just skip timestamp filling in this case).
gavv
added
needs revision
gavv
force-pushed
the
feature/udp_enqueue_ts
branch
from
2ee9ab4
to
d6a5801
Compare
github-actions
bot
removed
the
needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDP::enqueue_ts is filled in
ReceiverSession::route_packet() right before
the packet gets into jitter buffer queue.
#688