Fix unix-like platforms build #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semaphore.h is used in various places, and the implementation based on
unix semaphores is largely supported by unix platforms.
Fixes:
src/internal_modules/roc_ctl/control_task.h:20:10: fatal error: roc_core/semaphore.h: No such file or directory
20 | #include "roc_core/semaphore.h"
| ^~~~~~~~~~~~~~~~~~~~~~
|
🤖 Upon creation, pull request description does not have a link to an issue. If there is a related issue, please add it to the description using any of the supported formats. |
|
Thanks. I forgot that we have semaphore only for posix_ext and darwin right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semaphore.h is used in various places, and the implementation based on unix semaphores is largely supported by unix platforms.
Fixes:
src/internal_modules/roc_ctl/control_task.h:20:10: fatal error: roc_core/semaphore.h: No such file or directory
20 | #include "roc_core/semaphore.h"
| ^~~~~~~~~~~~~~~~~~~~~~