Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IDevice::close() #762

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Add IDevice::close() #762

merged 1 commit into from
Jul 28, 2024

Conversation

runei
Copy link

@runei runei commented Jul 18, 2024

Implements #748

@github-actions github-actions bot added the work in progress Pull request is still in progress and changing label Jul 18, 2024
@gavv gavv added the contribution A pull-request by someone else except maintainers label Jul 19, 2024
@runei runei marked this pull request as ready for review July 24, 2024 13:14
@github-actions github-actions bot added ready for review Pull request can be reviewed and removed work in progress Pull request is still in progress and changing labels Jul 24, 2024
gavv
gavv reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@gavv gavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the patch! There are a few problems, see below.

src/internal_modules/roc_pipeline/receiver_loop.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_pipeline/receiver_source.h Outdated Show resolved Hide resolved
src/internal_modules/roc_sndio/idevice.h Outdated Show resolved Hide resolved
src/tests/roc_sndio/test_helpers/mock_sink.h Outdated Show resolved Hide resolved
src/tests/roc_sndio/test_helpers/mock_source.h Outdated Show resolved Hide resolved
src/internal_modules/roc_sndio/target_sndfile/roc_sndio/sndfile_source.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_sndio/target_sox/roc_sndio/sox_sink.cpp Show resolved Hide resolved
src/internal_modules/roc_sndio/target_sox/roc_sndio/sox_source.cpp Show resolved Hide resolved
src/internal_modules/roc_sndio/target_sox/roc_sndio/sox_sink.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_sndio/target_sox/roc_sndio/sox_source.cpp Outdated Show resolved Hide resolved
@gavv gavv added needs revision Pull request should be revised by its author and removed ready for review Pull request can be reviewed labels Jul 25, 2024
@runei runei requested a review from gavv July 27, 2024 16:11
@github-actions github-actions bot added ready for review Pull request can be reviewed and removed needs revision Pull request should be revised by its author labels Jul 27, 2024
@gavv gavv added this to the next milestone Jul 28, 2024
@gavv gavv merged commit 1818806 into roc-streaming:develop Jul 28, 2024
1 check passed
@github-actions github-actions bot removed the ready for review Pull request can be reviewed label Jul 28, 2024
@gavv
Copy link
Member

gavv commented Jul 28, 2024

Thanks! Follow-up commit: 39b93c6 (see commit message for details)

@runei runei deleted the develop_748 branch July 29, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavv gavv Awaiting requested review from gavv

Assignees
No one assigned
Labels
contribution A pull-request by someone else except maintainers
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@runei @gavv