feat: Switch to mjml to handle email templates #1527
+3,026
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsforza
force-pushed
the
feat.email-mjml
branch
2 times, most recently
from
aa3edd0
to
e623b39
Compare
arsforza
force-pushed
the
feat.email-mjml
branch
from
e623b39
to
e1cd0ad
Compare
gulfaraz
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Reviewed over a call with @arsforza
Change Requests
- Breakpoint - email should take full width in mobile
- Font - use the same font as in the emails before this change
- Button border-radius - button-radius does not work in outlook
- Add space between button and text in mobile where the button and text is stacked instead of next to each other
- Add space after Advisory in the event text
- In event text it reads "from nows from now"
- Button labels are different (maybe this gets fixed after merge to master)
- Open IBF
- Join WhatsApp
- About Trigger
- Mailchimp footer does not match the old emails
- Do a manual comparison of the copy from the emails generated in the master branch
Relevant Links
|
@arsforza I missed one change in our review call. Let's use date-fns instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1515
Describe your changes
Checklist before requesting a review