Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible Configuration + Pull Latest Version #13

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

Shackelford-Arden
Copy link
Contributor

Was about to go roll my own role for installing Starship, when I found your role 😄

Mainly for me, I wanted to be able to install the binary per-user vs for the whole system. Some of the machines I use are shared systems and didn't want to potentially clutter up other folks.

I'm also a roll forward kind of guy, so I added the ability to pull from the latest release.

Molecule is new to me, but I also included tests that show the new pieces working with all of the existing tests still passing.

@tboerger
Copy link
Member

Thanks for the effort you put into that. For an optional different path and ownership I'm really in. But I would rather avoid the latest version integration as this is not really a reproducable action. The version of Starship gets automatically updated after releases of the upstream project based on Renovate and this also gets properly versioned automatically.

If you really always need to get the latest version you could also just use the latest version of the role. The versioning gets as mentioned above always incremented automatically.

@Shackelford-Arden
Copy link
Contributor Author

Sounds fair to me 😄 I've updated accordingly

Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I would stick with the old style without the full qualified resource names for now. I think I will change that for all my role later on with a major version bump.

Beside that please follow https://www.conventionalcommits.org/en/v1.0.0/, otherwise the changelog can't get generated automatically :)

Taskfile.yml Outdated Show resolved Hide resolved
molecule/default/prepare.yml Outdated Show resolved Hide resolved
@tboerger
Copy link
Member

tboerger commented Feb 2, 2024

I will merge this PR as it is for now and will push a followup to apply a little bit more than that. Thanks for you contribution!

@tboerger tboerger merged commit a665f30 into rolehippie:master Feb 2, 2024
2 of 3 checks passed
@bothippie
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Shackelford-Arden
Copy link
Contributor Author

Thanks for being patient with me and working with me on contributing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants