Skip to content

Commit

Permalink
[ntuple] Remove incorrect std::vector::reserve
Browse files Browse the repository at this point in the history
This was added in commit d950e99 ("[ntuple] use RClusterPool in
RNTupleMerger") with no explicit mention, and I believe it's wrong
because every column yields exactly one page group that contains all
pages for that column.
  • Loading branch information
hahnjo committed Jul 19, 2024
1 parent 7730491 commit 5738825
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions tree/ntuple/v7/src/RNTupleMerger.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,6 @@ void ROOT::Experimental::Internal::RNTupleMerger::Merge(std::span<RPageSource *>
if (colRangeCompressionSettings != 0)
sealedPageBuffers.resize(sealedPageBuffers.size() + pages.fPageInfos.size());

sealedPageGroups.reserve(sealedPageGroups.size() + pages.fPageInfos.size());

std::uint64_t pageIdx = 0;

// Loop over the pages
Expand Down

0 comments on commit 5738825

Please sign in to comment.