Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[textinput] right or left arrow introduce stray characters while history search #10209

Closed
ferdymercury opened this issue Mar 23, 2022 · 0 comments · Fixed by #10281
Closed

[textinput] right or left arrow introduce stray characters while history search #10209

ferdymercury opened this issue Mar 23, 2022 · 0 comments · Fixed by #10281
Assignees
@jalopezg-git
Labels
affects:master bug in:Core Libraries
Milestone
6.28/00

Comments

@ferdymercury
Copy link
Collaborator

ferdymercury commented Mar 23, 2022 •
edited
Loading

Describe the bug

When you are within a search in the ROOT prompt (CTRL+R), pressing right arrow or left arrow selects the current match, but also introduces stray characters [D, [C or similar. Which have then to be erased by hand.
Something similar is found if you press Ctrl+Right_arrow or Ctrl+Left_Arrow

Expected behavior

The same, but without the stray characters being added.

To Reproduce

  • Open ROOT prompt
  • CTRL+R
  • Type something
  • Press right arrow

Setup

   ------------------------------------------------------------------
  | Welcome to ROOT 6.27/01                        https://root.cern |
  | (c) 1995-2022, The ROOT Team; conception: R. Brun, F. Rademakers |
  | Built for linuxx8664gcc on Mar 23 2022, 09:52:37                 |
  | From heads/forwardsearch@v6-25-01-3646-g14443be956               |
  | With g++ (Ubuntu 8.4.0-1ubuntu1~18.04) 8.4.0                     |
  | Try '.help'/'.?', '.demo', '.license', '.credits', '.quit'/'.q'  |
   ------------------------------------------------------------------

Additional context

#10121
@ferdymercury ferdymercury added this to the 6.28/00 milestone Mar 23, 2022
jalopezg-git added a commit to jalopezg-git/root that referenced this issue Mar 29, 2022
@jalopezg-git
[textinput] Do not assign ESC a special meaning on history search mode
bed9e2c 
UNIX terminals, e.g. vt100, send escape sequences for many special
key combinations. Entering the history search mode assigned a specific
meaning to the ESC character and disabled the processing of escape
sequences, thus accidentally printing some characters that are part
of a CSI.

As a workaround, avoid changing the meaning of ESC; users can still
use the well-known `ESC ESC` sequence (or any other editor command,
e.g. move left/right) to exit the history search mode.

Closes issue root-project#10209.
jalopezg-git added a commit to jalopezg-git/root that referenced this issue Mar 29, 2022
@jalopezg-git
[textinput] Do not assign ESC a special meaning on history search mode
b63bb18 
UNIX terminals, e.g. vt100, send escape sequences for many special
key combinations. Entering the history search mode assigned a specific
meaning to the ESC character and disabled the processing of escape
sequences, thus accidentally printing some characters that are part
of a CSI.

As a workaround, avoid changing the meaning of ESC; users can still
use the well-known `ESC ESC` sequence (or any other editor command,
e.g. move left/right) to exit the history search mode.

This change only affects UNIX terminals.

Closes issue root-project#10209.
@ferdymercury ferdymercury mentioned this issue Mar 30, 2022
Merged
2 tasks
jalopezg-git added a commit to jalopezg-git/root that referenced this issue Mar 31, 2022
@jalopezg-git
[textinput] Do not assign ESC a special meaning on history search mode
5682e73 
UNIX terminals, e.g. vt100, send escape sequences for many special
key combinations. Entering the history search mode assigned a specific
meaning to the ESC character and disabled the processing of escape
sequences, thus accidentally printing some characters that are part
of a CSI.

As a workaround, avoid changing the meaning of ESC; users can still
use the well-known `ESC ESC` sequence (or any other editor command,
e.g. move left/right) to exit the history search mode.

This change only affects UNIX terminals.

Closes issue root-project#10209.
@jalopezg-git jalopezg-git mentioned this issue Mar 31, 2022
Merged
1 task
jalopezg-git added a commit that referenced this issue Mar 31, 2022
@jalopezg-git
[textinput] Do not assign ESC a special meaning on history search mode
8a533e4 
UNIX terminals, e.g. vt100, send escape sequences for many special
key combinations. Entering the history search mode assigned a specific
meaning to the ESC character and disabled the processing of escape
sequences, thus accidentally printing some characters that are part
of a CSI.

As a workaround, avoid changing the meaning of ESC; users can still
use the well-known `ESC ESC` sequence (or any other editor command,
e.g. move left/right) to exit the history search mode.

This change only affects UNIX terminals.

Closes issue #10209.
Neel-Shah-29 pushed a commit to Neel-Shah-29/root-1 that referenced this issue Apr 6, 2022
@jalopezg-git
[textinput] Do not assign ESC a special meaning on history search mode
4517d6d 
UNIX terminals, e.g. vt100, send escape sequences for many special
key combinations. Entering the history search mode assigned a specific
meaning to the ESC character and disabled the processing of escape
sequences, thus accidentally printing some characters that are part
of a CSI.

As a workaround, avoid changing the meaning of ESC; users can still
use the well-known `ESC ESC` sequence (or any other editor command,
e.g. move left/right) to exit the history search mode.

This change only affects UNIX terminals.

Closes issue root-project#10209.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jalopezg-git jalopezg-git

Labels
affects:master bug in:Core Libraries
Projects
None yet
Milestone
6.28/00
Development

Successfully merging a pull request may close this issue.

[textinput] Do not assign ESC a special meaning on history search mode jalopezg-git/root
2 participants
@ferdymercury @jalopezg-git