Failing Cling tests with multiple interpreters #12455
Assignees
Labels
Comments
2 tasks
jalopezg-git
added a commit
to jalopezg-git/root
that referenced
this issue
May 30, 2023
Prior to the upgrade to LLVM13, child interpreters used to also lookup symbols in their parent. This commit introduces a `DefinitionGenerator` that allows for symbol lookup across different `IncrementalJIT` instances, which restores the old behavior. This change fixes the following tests: - CodeUnloading/AtExit.C - MultipleInterpreters/MultipleInterpreters.C Fixes root-project#12455.
jalopezg-git
added a commit
to jalopezg-git/root
that referenced
this issue
May 30, 2023
Prior to the upgrade to LLVM13, child interpreters used to also lookup symbols in their parent. This commit introduces a `DefinitionGenerator` that allows for symbol lookup across different `IncrementalJIT` instances, which restores the old behavior. This change fixes the following tests: - CodeUnloading/AtExit.C - MultipleInterpreters/MultipleInterpreters.C Fixes root-project#12455.
This was referenced May 30, 2023
jalopezg-git
added a commit
that referenced
this issue
May 31, 2023
Prior to the upgrade to LLVM13, child interpreters used to also lookup symbols in their parent. This commit introduces a `DefinitionGenerator` that allows for symbol lookup across different `IncrementalJIT` instances, which restores the old behavior. This change fixes the following tests: - CodeUnloading/AtExit.C - MultipleInterpreters/MultipleInterpreters.C Fixes #12455.
jalopezg-git
added a commit
that referenced
this issue
May 31, 2023
Prior to the upgrade to LLVM13, child interpreters used to also lookup symbols in their parent. This commit introduces a `DefinitionGenerator` that allows for symbol lookup across different `IncrementalJIT` instances, which restores the old behavior. This change fixes the following tests: - CodeUnloading/AtExit.C - MultipleInterpreters/MultipleInterpreters.C Fixes #12455.
|
Hi @jalopezg-git, @Axel-Naumann, @vgvassilev, It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise. Sincerely, |
|
Hi @jalopezg-git, @Axel-Naumann, @vgvassilev, It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise. Sincerely, |
maksgraczyk
pushed a commit
to maksgraczyk/root
that referenced
this issue
Jun 28, 2023
Prior to the upgrade to LLVM13, child interpreters used to also lookup symbols in their parent. This commit introduces a `DefinitionGenerator` that allows for symbol lookup across different `IncrementalJIT` instances, which restores the old behavior. This change fixes the following tests: - CodeUnloading/AtExit.C - MultipleInterpreters/MultipleInterpreters.C Fixes root-project#12455.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since the upgrade to LLVM 13, at least two tests are failing because of broken interactions with multiple interpreters:
CodeUnloading/AtExit.Cdoes not find the symbolgChild.MultipleInterpreters/MultipleInterpreters.Ccannot find the symbol_ZN5cling7runtime6gClingE/cling::runtime::gClingduringChildInterp.echo()(the first usage to constructcling::Interpreter ChildInterp(*gCling, 1, argV);seems fine).Based on this, one might theorize that the child interpreter doesn't have access to symbols declared in its parent (not sure how this worked before).
The text was updated successfully, but these errors were encountered: