[do not merge] [runtime-cxxmodules] Rework our lazy template specialization deserialization mechanism #14495

vgvassilev · 2024-01-31T09:18:34Z

This PR tries to make progress with upstreaming our lazy template specialization patch lives only in our llvm forks ( https://reviews.llvm.org/D41416) in favor of re-implementing it in a way that we can upstream it (llvm/llvm-project#76774)

phsft-bot · 2024-01-31T09:18:41Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2024-01-31T10:47:41Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_pretty_printing

hahnjo · 2024-01-31T10:56:31Z

I believe you need the "clean build" label here to avoid incremental builds tripping over the old pcms...

phsft-bot · 2024-01-31T12:12:32Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_pretty_printing

vgvassilev · 2024-01-31T14:29:51Z

I believe you need the "clean build" label here to avoid incremental builds tripping over the old pcms...

I am lost -- was only triggering a rebuild enough? If so, then I find it hard to believe we cannot compile root without these patches.

hahnjo · 2024-01-31T14:34:56Z

I believe you need the "clean build" label here to avoid incremental builds tripping over the old pcms...

I am lost -- was only triggering a rebuild enough? If so, then I find it hard to believe we cannot compile root without these patches.

No you need a new workflow run (just push an empty commit or amend the last to get a new commit hash) - the state of labels is recorded at the beginning to avoid some builds running with different settings than others

phsft-bot · 2024-01-31T14:41:02Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2024-01-31T15:42:30Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_pretty_printing

phsft-bot · 2024-01-31T16:13:36Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_pretty_printing

github-actions · 2024-01-31T21:44:32Z

Test Results

11 files 11 suites 1d 19h 27m 24s ⏱️
2 581 tests 2 580 ✅ 0 💤 1 ❌
26 537 runs 26 536 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 552a7b4.

♻️ This comment has been updated with latest results.

phsft-bot · 2024-02-01T14:54:58Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2024-02-01T15:20:05Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2024-02-01T15:18:48.975Z] FAILED: interpreter/cling/tools/plugins/clad/clad-prefix/src/clad-stamp/clad-download /home/sftnight/build/workspace/root-pullrequests-build/build/interpreter/cling/tools/plugins/clad/clad-prefix/src/clad-stamp/clad-download
[2024-02-01T15:18:48.975Z] CMake Error at clad-stamp/clad-download-Release.cmake:37 (message):
[2024-02-01T15:18:48.975Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/build/interpreter/cling/tools/plugins/clad/clad-prefix/tmp/clad-gitclone.cmake:39 (message):
[2024-02-01T15:18:48.975Z] CMake Error at clad-stamp/clad-download-Release.cmake:47 (message):

phsft-bot · 2024-02-01T15:33:24Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2024-02-01T15:32:24.340Z] CMake Error at clad-stamp/clad-download-Release.cmake:37 (message):
[2024-02-01T15:32:24.340Z] Please make sure yCMake Error at clad-stamp/clad-download-Release.cmake:47 (message):
[2024-02-01T15:32:24.340Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/build/interpreter/cling/tools/plugins/clad/clad-prefix/tmp/clad-gitclone.cmake:39 (message):

phsft-bot · 2024-02-01T15:41:04Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2024-02-01T16:03:54Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_pretty_printing

phsft-bot · 2024-02-01T16:23:27Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_pretty_printing

vgvassilev · 2024-02-01T21:58:52Z

@hahnjo, according to our ci this patch seems fine.

@smuzaffar, can we run this PR against cmssw?

cc: @ChuanqiXu9

hahnjo · 2024-02-02T07:43:43Z

@hahnjo, according to our ci this patch seems fine.

IIUC LoadExternalSpecializationsLazily is still off by default, right? But good that it passes now in this off-by-default mode 👍

smuzaffar · 2024-02-02T09:23:45Z

@smuzaffar, can we run this PR against cmssw?

CMSSW tests are running via cms-sw#198 (note that cmssw tests are running for non-CXXMODULES builds)

phsft-bot · 2024-02-03T11:46:22Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

vgvassilev · 2024-02-03T11:46:58Z

@smuzaffar, can we run this PR against cmssw?

CMSSW tests are running via cms-sw#198 (note that cmssw tests are running for non-CXXMODULES builds)

@smuzaffar, can you interpret the results?

phsft-bot · 2024-02-03T12:15:04Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_pretty_printing

phsft-bot · 2024-02-03T12:27:51Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_pretty_printing

ChuanqiXu9 · 2024-03-04T11:10:13Z

Wow, this looks worse than my original patch. But it shows these errors are build time errors instead of runtime errors. It is slightly odd to me.

Yes, it fails during ROOT's build but already in a stage where we are running some built tools to build our modules. This involves loading modules of dependent libraries, so it will trigger the template specialization loading logic.

Got it. Thanks.

@vgvassilev It turns out that the reason for so many failures is we have an ExternalASTSource in root out of the llvm tree, so we don't update that. ChuanqiXu9@570fd78

There is also another bug about the order to remove iterators: ChuanqiXu9@7fb4aa9

Now I can build the project in https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/. I only run make instead of ctest. But it may be fine as we said the logic happens at build time actually. I think you can push the 2 commits to the branch to test it with the CI again.

phsft-bot · 2024-03-05T07:49:43Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

vgvassilev · 2024-03-05T07:50:14Z

Wow, this looks worse than my original patch. But it shows these errors are build time errors instead of runtime errors. It is slightly odd to me.

Yes, it fails during ROOT's build but already in a stage where we are running some built tools to build our modules. This involves loading modules of dependent libraries, so it will trigger the template specialization loading logic.

Got it. Thanks.

@vgvassilev It turns out that the reason for so many failures is we have an ExternalASTSource in root out of the llvm tree, so we don't update that. ChuanqiXu9@570fd78

There is also another bug about the order to remove iterators: ChuanqiXu9@7fb4aa9

Now I can build the project in https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/. I only run make instead of ctest. But it may be fine as we said the logic happens at build time actually. I think you can push the 2 commits to the branch to test it with the CI again.

@ChuanqiXu9, that is really awesome! Apologies for the oversight of the ExternalASTSource. I've pushed these changes and let's see what happens.

vgvassilev · 2024-03-05T11:36:36Z

Wow, this looks worse than my original patch. But it shows these errors are build time errors instead of runtime errors. It is slightly odd to me.

Yes, it fails during ROOT's build but already in a stage where we are running some built tools to build our modules. This involves loading modules of dependent libraries, so it will trigger the template specialization loading logic.

Got it. Thanks.
@vgvassilev It turns out that the reason for so many failures is we have an ExternalASTSource in root out of the llvm tree, so we don't update that. ChuanqiXu9@570fd78
There is also another bug about the order to remove iterators: ChuanqiXu9@7fb4aa9
Now I can build the project in https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/. I only run make instead of ctest. But it may be fine as we said the logic happens at build time actually. I think you can push the 2 commits to the branch to test it with the CI again.

@ChuanqiXu9, that is really awesome! Apologies for the oversight of the ExternalASTSource. I've pushed these changes and let's see what happens.

@ChuanqiXu9, the tests look good on our side. I will compare performance but I think we should bring these changes to the upstream pull request and ask the google folks to test the scalability of the patch.

ChuanqiXu9 · 2024-03-05T11:44:59Z

@vgvassilev Great!

For performances, it looks like you lack a commit from the branch https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/, which tries to reduce the time we calculating the ODR Hash.

vgvassilev · 2024-03-05T11:48:43Z

@vgvassilev Great!

For performances, it looks like you lack a commit from the branch https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/, which tries to reduce the time we calculating the ODR Hash.

Do you mean this one: ChuanqiXu9@2467fe7 ?

hahnjo · 2024-03-05T11:48:44Z

@vgvassilev FYI mac14arm fails to build the dictionary for TMVAUtils, with a crash in cling::DeclCollector::HandleInterestingDecl...

ChuanqiXu9 · 2024-03-05T11:49:32Z

@vgvassilev Great!
For performances, it looks like you lack a commit from the branch https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/, which tries to reduce the time we calculating the ODR Hash.

Do you mean this one: ChuanqiXu9@2467fe7 ?

Yes

vgvassilev · 2024-03-05T11:51:41Z

@vgvassilev FYI mac14arm fails to build the dictionary for TMVAUtils, with a crash in cling::DeclCollector::HandleInterestingDecl...

Ha, ok, until now I only saw Failed to open the S3 connection: You must provide an auth secret.. That might be "just" missing a PushTransactionRAII on our side. Is there a way to build a debug + asserts version of that?

phsft-bot · 2024-03-05T12:01:19Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2024-03-05T12:20:17Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

…ion locally

phsft-bot · 2024-03-05T14:25:00Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2024-03-05T14:31:55Z

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2024-03-05T14:29:03.554Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:325:36: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.554Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:329:46: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.554Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:325:36: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.554Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:329:46: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.554Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:325:36: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.555Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:329:46: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.555Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:325:36: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.555Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:329:46: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.555Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:325:36: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context
[2024-03-05T14:29:03.555Z] /home/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:329:46: error: ‘template<class EntryType> struct clang::RedeclarableTemplateDecl::SpecEntryTraits’ is protected within this context

phsft-bot · 2024-03-05T14:58:47Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2024-03-05T14:40:00.763Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(343,21): error C2672: 'findSpecializationLocally': no matching overloaded function found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2024-03-05T14:40:00.763Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(342,1): error C2893: Failed to specialize function template 'RedeclarableTemplateDecl::SpecEntryTraits<EntryType>::DeclType findSpecializationLocally(llvm::FoldingSetVector<EntryType,llvm::SmallVector<T,8>> &,void *&,clang::ASTContext &,ProfileArguments &&...)' [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2024-03-05T14:40:03.262Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(342,1): error C3536: 'Found': cannot be used before it is initialized [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2024-03-05T14:40:03.262Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(345,12): error C2440: 'return': cannot convert from 'int' to 'clang::RedeclarableTemplateDecl::SpecEntryTraits<clang::FunctionTemplateSpecializationInfo>::DeclType *' [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2024-03-05T14:40:05.853Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(352,10): error C2672: 'findSpecializationLocally': no matching overloaded function found [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2024-03-05T14:40:05.853Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(345,12): error C2440: 'return': cannot convert from 'int' to 'clang::ClassTemplateSpecializationDecl *' [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2024-03-05T14:40:07.613Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(345,12): error C2440: 'return': cannot convert from 'int' to 'clang::ClassTemplatePartialSpecializationDecl *' [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2024-03-05T14:40:09.509Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(345,12): error C2440: 'return': cannot convert from 'int' to 'clang::VarTemplateSpecializationDecl *' [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2024-03-05T14:40:12.247Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\DeclTemplate.cpp(345,12): error C2440: 'return': cannot convert from 'int' to 'clang::VarTemplatePartialSpecializationDecl *' [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]

vgvassilev · 2024-03-05T15:10:37Z

@vgvassilev Great!
For performances, it looks like you lack a commit from the branch https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/, which tries to reduce the time we calculating the ODR Hash.

Do you mean this one: ChuanqiXu9@2467fe7 ?

Yes

@ChuanqiXu9, looks like the commit I took is broken. Did you forget to push your latest changes?

phsft-bot · 2024-03-05T15:14:21Z

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2024-03-05T15:14:15.451Z] FAILED: interpreter/llvm-project/llvm/tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/DeclTemplate.cpp.o
[2024-03-05T15:14:15.854Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:325:36: error: 'SpecEntryTraits' is a protected member of 'clang::RedeclarableTemplateDecl'
[2024-03-05T15:14:15.854Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/interpreter/llvm-project/clang/lib/AST/DeclTemplate.cpp:329:46: error: 'SpecEntryTraits' is a protected member of 'clang::RedeclarableTemplateDecl'

ChuanqiXu9 · 2024-03-05T15:15:52Z

@vgvassilev Great!
For performances, it looks like you lack a commit from the branch https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/, which tries to reduce the time we calculating the ODR Hash.

Do you mean this one: ChuanqiXu9@2467fe7 ?

Yes

@ChuanqiXu9, looks like the commit I took is broken. Did you forget to push your latest changes?

Weird. It compiles good locally. I don't know why it can work in my local environment as it accesses the protected type actually. I just tried to refactor this as the newest commit in https://github.com/ChuanqiXu9/root/commits/chuanqi_pr83233/

Since we need access the protect member in findSpecializationLocally

phsft-bot · 2024-03-05T19:54:11Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2024-03-05T21:24:57Z

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

vgvassilev · 2024-03-06T10:48:58Z

@ChuanqiXu9, this looks good on our side. Performance is also within the same ballpark. If I run /usr/bin/time -v root.exe -l -b -q tutorials/hsimple.C I get:

	master	this pr	this PR w/o ChuanqiXu9@2467fe7
user time:	0.53s	0.50s	0.49s
rss:	309436	310196	310192

It is surprising that we lose 1MB somewhere between D41416 and your changes...

@smuzaffar, can you test this PR against cmssw?

ChuanqiXu9 · 2024-03-06T10:54:49Z

@ChuanqiXu9, this looks good on our side. Performance is also within the same ballpark.

Great! I'll try to invite Google to test for it.

If I run /usr/bin/time -v root.exe -l -b -q tutorials/hsimple.C I get:

master this pr this PR w/o ChuanqiXu9@2467fe7
user time: 0.53s 0.50s 0.49s
rss: 309436 310196 310192
It is surprising that we lose 1MB somewhere between D41416 and your changes...

It looks like it is slightly faster (I know it is not accurate). The size overhead may comes from the hash table I guess. Time/Space trade offs. I guess it makes sense in the high level in some degree.

@smuzaffar, can you test this PR against cmssw?

hahnjo marked this pull request as draft January 31, 2024 09:32

hahnjo added the clean build Ask CI to do non-incremental build on PR label Jan 31, 2024

hahnjo assigned vgvassilev Jan 31, 2024

vgvassilev force-pushed the llvm-pr76774 branch from 0768c38 to 71937e9 Compare February 1, 2024 14:54

vgvassilev force-pushed the llvm-pr76774 branch from 71937e9 to 3387aa4 Compare February 1, 2024 15:40

smuzaffar mentioned this pull request Feb 2, 2024

[do not merge] [runtime-cxxmodules] Rework our lazy template specialization deserialization mechanism cms-sw/root#198

Closed

vgvassilev force-pushed the llvm-pr76774 branch from 637378e to f714dda Compare February 3, 2024 14:05

ChuanqiXu9 added 2 commits March 5, 2024 07:49

Update out of tree external sources

1c36e0e

Remove iterator before GetDecl

5b46e86

TraverseDecl might deserialize

92ee19a

vgvassilev force-pushed the llvm-pr76774 branch from 9e4125f to 92ee19a Compare March 5, 2024 12:20

root-project deleted a comment from phsft-bot Mar 5, 2024

Avoid loading external specializations if we can find the specializat…

37d5004

…ion locally

Add findSpecializationLocally as a member of RedeclarableTemplateDecl

552a7b4

Since we need access the protect member in findSpecializationLocally

ferdymercury added the in:Cling label Apr 15, 2024

[do not merge] [runtime-cxxmodules] Rework our lazy template specialization deserialization mechanism #14495

Are you sure you want to change the base?

[do not merge] [runtime-cxxmodules] Rework our lazy template specialization deserialization mechanism #14495

Conversation

vgvassilev commented Jan 31, 2024

phsft-bot commented Jan 31, 2024

phsft-bot commented Jan 31, 2024

Failing tests:

hahnjo commented Jan 31, 2024 • edited Loading

phsft-bot commented Jan 31, 2024

Failing tests:

vgvassilev commented Jan 31, 2024

hahnjo commented Jan 31, 2024

phsft-bot commented Jan 31, 2024

phsft-bot commented Jan 31, 2024

Failing tests:

phsft-bot commented Jan 31, 2024

Failing tests:

github-actions bot commented Jan 31, 2024 • edited Loading

Test Results

phsft-bot commented Feb 1, 2024

phsft-bot commented Feb 1, 2024

Errors:

phsft-bot commented Feb 1, 2024

Errors:

phsft-bot commented Feb 1, 2024

phsft-bot commented Feb 1, 2024

Failing tests:

phsft-bot commented Feb 1, 2024

Failing tests:

vgvassilev commented Feb 1, 2024

hahnjo commented Feb 2, 2024

smuzaffar commented Feb 2, 2024

phsft-bot commented Feb 3, 2024

vgvassilev commented Feb 3, 2024

phsft-bot commented Feb 3, 2024

Failing tests:

phsft-bot commented Feb 3, 2024

Failing tests:

ChuanqiXu9 commented Mar 4, 2024

phsft-bot commented Mar 5, 2024

vgvassilev commented Mar 5, 2024

vgvassilev commented Mar 5, 2024

ChuanqiXu9 commented Mar 5, 2024

vgvassilev commented Mar 5, 2024

hahnjo commented Mar 5, 2024

ChuanqiXu9 commented Mar 5, 2024

vgvassilev commented Mar 5, 2024

phsft-bot commented Mar 5, 2024

phsft-bot commented Mar 5, 2024

phsft-bot commented Mar 5, 2024

phsft-bot commented Mar 5, 2024

Errors:

phsft-bot commented Mar 5, 2024

Errors:

vgvassilev commented Mar 5, 2024

phsft-bot commented Mar 5, 2024

Errors:

ChuanqiXu9 commented Mar 5, 2024

phsft-bot commented Mar 5, 2024

phsft-bot commented Mar 5, 2024

Failing tests:

vgvassilev commented Mar 6, 2024 • edited Loading

ChuanqiXu9 commented Mar 6, 2024

hahnjo commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

vgvassilev commented Mar 6, 2024 •

edited

Loading