Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [runtime_cxxmodules] Fix libcxx on osx14.3 #14941

Merged
merged 6 commits into from
Mar 16, 2024
Merged

[Backport] [runtime_cxxmodules] Fix libcxx on osx14.3 #14941

merged 6 commits into from
Mar 16, 2024

Conversation

dpiparo
Copy link
Member

@dpiparo dpiparo commented Mar 12, 2024

@dpiparo dpiparo self-assigned this Mar 12, 2024
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited
Loading

Test Results

    12 files      12 suites   2d 6h 18m 35s ⏱️
 2 586 tests  2 585 ✅ 0 💤 1 ❌
29 045 runs  29 044 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit bae44bb.

♻️ This comment has been updated with latest results.

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2024-03-12T12:10:44.709Z] LINK : fatal error LNK1104: cannot open file 'C:\build\workspace\root-pullrequests-build\build\bin\libCore.dll' [C:\build\workspace\root-pullrequests-build\build\core\Core.vcxproj]

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2024-03-12T14:22:38.570Z] FAILED: core/G__Core.cxx lib/Core.pcm

@phsft-bot
Copy link
Collaborator

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2024-03-12T14:44:16.659Z] FAILED: core/G__Core.cxx lib/Core.pcm /Users/sftnight/build/workspace/root-pullrequests-build/build/core/G__Core.cxx /Users/sftnight/build/workspace/root-pullrequests-build/build/lib/Core.pcm

@dpiparo dpiparo requested a review from pcanal as a code owner March 14, 2024 16:37
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@zygoloid @vgvassilev
An expression should only contain an unexpanded parameter pack if it …
bae44bb 
…lexically contains a mention of the pack.

Systematically distinguish between syntactic and semantic references to
packs, especially when propagating dependence from a type into an
expression. We should consult the type-as-written when computing
syntactic dependence and should consult the semantic type when computing
semantic dependence.

Fixes #54402.
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@dpiparo
Copy link
Member Author

dpiparo commented Mar 16, 2024

I am merging this PR to turn 6.30 builds green, which is a priority. Next week, we'll discuss how to properly handle the backports in the monorepo. We can always revert this PR or part of its commits.

@dpiparo dpiparo merged commit 52e1488 into root-project:v6-30-00-patches Mar 16, 2024
14 of 18 checks passed
@dpiparo dpiparo mentioned this pull request Mar 16, 2024
Merged
@dpiparo
Copy link
Member Author

dpiparo commented Mar 16, 2024

Same approach adopted for 6.28 #14988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann Axel-Naumann is a code owner

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

@vgvassilev vgvassilev Awaiting requested review from vgvassilev vgvassilev is a code owner

Assignees

@dpiparo dpiparo

Labels
pr:backport priority:critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dpiparo @phsft-bot @vgvassilev @zygoloid