[Clang] Implement CWG2518 - static_assert(false) #15437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Test Results 11 files 11 suites 2d 13h 44m 43s ⏱️ Results for commit b6f480e. ♻️ This comment has been updated with latest results. |
|
We've verified that your patch fixes Root with our in-development compiler and STL, thanks! |
bellenot
approved these changes
May 13, 2024
There was a problem hiding this comment.
Following the confirmation from @StephanTLavavej that this PR fixes the issue
This allows `static_assert(false)` to not be ill-formed in template definitions. This change is applied as a DR in all C++ modes. Of notes, a couple of tests were relying of the eager nature of static_assert * test/SemaTemplate/instantiation-dependence.cpp * test/SemaTemplate/instantiate-var-template.cpp I don't know if the changes to `static_assert` still allow that sort of tests to be expressed. Reviewed By: #clang-language-wg, erichkeane, aaron.ballman Differential Revision: https://reviews.llvm.org/D144285 --- Fixes the build with newer versions of MSVC's STL, reported as root-project#15321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
static_assert(false)to not be ill-formed in template definitions.This change is applied as a DR in all C++ modes.
Of notes, a couple of tests were relying of the eager nature of static_assert
I don't know if the changes to
static_assertstill allow that sort of tests to be expressed.
Reviewed By: #clang-language-wg, erichkeane, aaron.ballman
Differential Revision: https://reviews.llvm.org/D144285
Fixes the build with newer versions of MSVC's STL, reported as #15321