-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Add ninja support for Windows #15635
base: master
Are you sure you want to change the base?
Changes from 6 commits
73e6217
6c8eb68
00a3b14
0fe94e1
1f15273
19dcc3e
c89a065
4801e91
213eca2
181842a
e1443bf
4cc8d43
5815afb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,13 +13,19 @@ foreach(var PCRE_FOUND PCRE_VERSION PCRE_INCLUDE_DIR PCRE_PCRE_LIBRARY PCRE_LIBR | |
endforeach() | ||
|
||
if(WIN32) | ||
if(winrtdebug) | ||
set(PCRE_POSTFIX $<$<CONFIG:Debug>:d>) | ||
set(pcre_config_kind "Debug") | ||
if(CMAKE_GENERATOR MATCHES Ninja) | ||
if (CMAKE_BUILD_TYPE MATCHES Debug) | ||
set(PCRE_POSTFIX d) | ||
pcanal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
endif() | ||
else() | ||
set(pcre_config_kind "Release") | ||
if(winrtdebug) | ||
set(PCRE_POSTFIX $<$<CONFIG:Debug>:d>) | ||
set(pcre_config_kind "Debug") | ||
else() | ||
set(pcre_config_kind "Release") | ||
endif() | ||
set(pcre_config "--config") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wait, is this not in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code is correct, but I'll make it more clear |
||
endif() | ||
set(pcre_config "--config") | ||
endif() | ||
|
||
set(PCRE_VERSION "8.43" CACHE INTERNAL "" FORCE) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2136,6 +2136,10 @@ void AddPlatformDefines(std::vector<std::string> &clingArgs) | |
clingArgs.push_back(platformDefines); | ||
snprintf(platformDefines, 64, "-DG__VISUAL=%ld", (long)_MSC_VER); | ||
clingArgs.push_back(platformDefines); | ||
#if defined(_WIN64) && defined(_DEBUG) | ||
snprintf(platformDefines, 64, "-D_ITERATOR_DEBUG_LEVEL=0"); //, (long)_ITERATOR_DEBUG_LEVEL); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does that fix: "the I/O is still broken in debug mode, due to the special iterators on x64," ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately not, it's just a workaround. The problem is that one can only link the ROOT libraries in debug mode if they use the same flag with their software. Even worse, the externals have to be built with the same flag (e.g. I had the issue with Pythia8)! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok. |
||
clingArgs.push_back(platformDefines); | ||
#endif | ||
#endif | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. the
if()
-else()
test is for ninja only, independently of the build type