Fix build with MacOSX15.0.sdk and disable clad on mac-beta [v6.32]
#15911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually curating the modulemap is far from ideal because it requires updates for changes in the libc++ library shipped with the SDK, which must also work across all supported SDK versions. An alternative would be to locate the modulemap shipped with libc++ during configuration time, copy it and dynamically modify its contents to suit our needs. (cherry picked from commit ece4c81)
When an include from a textual header is resolved, the textual header's submodule is used as the requesting module. The submodule's uses are resolved, but that doesn't work because only top level modules have uses, and only the top level module uses are used for checking uses in Module::directlyUses. ModuleMap::resolveUses to resolve the top level module instead of the submodule. --- This fixes the build of std.pcm with MacOSX15.0.sdk. (cherry picked from commit bb9629d)
Clad currently has problems with some new headers in MacOSX15.0.sdk and crashes / errors due to __builtin_pow. Disable it for now while a solution is worked on, so we can upgrade the nodes and keep the build green. (cherry picked from commit c3264ca)
Test Results 11 files 11 suites 2d 11h 44m 56s ⏱️ Results for commit 337eb4c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of #15900 and #15910