Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doxygen] use jsroot v7 modules for embeding #16023

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

linev
Copy link
Member

@linev linev commented Jul 12, 2024

Let use browser import() function to control proper loading of JSROOT modules.
No need to use older JSRoot.core.js

To be tested

Use normal import function to control proper loading
of JSROOT modules. No need to use older JSRoot.core.js
Copy link
Member

@couet couet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@linev
Copy link
Member Author

linev commented Jul 26, 2024

Did you check that docs working afterwards. Feature enabled for arrow.C macro.

@linev linev merged commit 26f20db into root-project:master Sep 2, 2024
1 check failed
@linev linev deleted the newjs_doxygen branch September 2, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants