[CMake] Always use lib as library directory in builtin CFITSIO prefix
#16065
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like this, we make sure the static library is where we expect it to be: `CFITSIO-prefix/lib/libcfitsio.a`, and not for example in the `lib64` directory. Inspired by this forum post: https://root-forum.cern.ch/t/6-32-02-will-not-build-from-source-with-option-dbuiltin-cfitsio/60270
Test Results 13 files 13 suites 3d 2h 11m 36s ⏱️ Results for commit 18bc7f9. |
bellenot
approved these changes
Jul 19, 2024
|
Merging, since the user confirmed that it solves the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like this, we make sure the static library is where we expect it to be:
CFITSIO-prefix/lib/libcfitsio.a, and not for example in thelib64directory.This is already done for other builtins, like
xrootdandzeromq.Inspired by this forum post:
https://root-forum.cern.ch/t/6-32-02-will-not-build-from-source-with-option-dbuiltin-cfitsio/60270