[v632] Backport of recent fixes and improvements #16071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two implementations are provided, i.e. for Python versions older than 3.8, for which PEP 587 is not in force, and newer. Credit goes to Danilo Piparo (@dpiparo), who originally made this change for ROOTs TPython: root-project#13532 This is a port of the following commit to upstream CPyCppyy: wlav/CPyCppyy#31
Now that the CPyCppyy::ExecScript method is synced with the TPython version, we can just call the CPyCppyy API in TPython::ExecScript.
Like this, we make sure the static library is where we expect it to be: `CFITSIO-prefix/lib/libcfitsio.a`, and not for example in the `lib64` directory. Inspired by this forum post: https://root-forum.cern.ch/t/6-32-02-will-not-build-from-source-with-option-dbuiltin-cfitsio/60270
The memory leaks were introduced on purpose in that test, but they are probably not necessary anymore. Also, suppress unneeded logging and format code.
guitargeek
requested review from
bellenot,
lmoneta,
dpiparo and
vepadulano
as code owners
Test Results 11 files 11 suites 2d 13h 50m 3s ⏱️ For more details on these failures, see this check. Results for commit e411021. ♻️ This comment has been updated with latest results. |
guitargeek
merged commit bbc6b0d
into
root-project:v6-32-00-patches
22 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of recent fixes and improvements for the upcoming patch release.