Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] fix compile error in RWebWindowsManager.cxx #16072

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

silverweed
Copy link
Contributor

@silverweed silverweed commented Jul 19, 2024

Fix compile error (happening with DEV=on due to missing include):

/home/jp/root/gui/webdisplay/src/RWebWindowsManager.cxx:215:13: error: no matching constructor for initialization of 'TIter'
      TIter next(arr);
            ^    ~~~
/home/jp/root/core/cont/inc/TCollection.h:244:4: note: candidate constructor not viable: cannot convert argument of incomplete type 'TObjArray *' to 'const TCollection *' for 1st argument
   TIter(const TCollection *col, Bool_t dir = kIterForward)
   ^
/home/jp/root/core/cont/inc/TCollection.h:246:4: note: candidate constructor not viable: cannot convert argument of incomplete type 'TObjArray *' to 'TIterator *' for 1st argument
   TIter(TIterator *it) : fIterator(it) { }
   ^
/home/jp/root/core/cont/inc/TCollection.h:247:4: note: candidate constructor not viable: cannot convert argument of incomplete type 'TObjArray *' to 'const TIter' for 1st argument
   TIter(const TIter &iter);
   ^
/home/jp/root/core/cont/inc/TCollection.h:241:4: note: candidate constructor not viable: requires 0 arguments, but 1 was provided
   TIter() : fIterator(nullptr) { }
   ^
/home/jp/root/gui/webdisplay/src/RWebWindowsManager.cxx:229:7: error: deleting pointer to incomplete type 'TObjArray' may cause undefined behavior [-Werror,-Wdelete-incomplete]
      delete arr;
      ^      ~~~
/home/jp/root/core/base/inc/TObject.h:32:7: note: forward declaration of 'TObjArray'
class TObjArray;
      ^

@silverweed silverweed requested a review from bellenot July 19, 2024 15:10
@silverweed silverweed self-assigned this Jul 19, 2024
@silverweed silverweed requested a review from linev as a code owner July 19, 2024 15:10
@silverweed silverweed added the pr:emergency🚨 This PR is fixing breakage, it's urgent and may overtake others label Jul 19, 2024
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@silverweed silverweed merged commit d4c8fa6 into root-project:master Jul 19, 2024
17 checks passed
@silverweed silverweed deleted the rwebwindowsmanager_fix branch July 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:WebGui pr:emergency🚨 This PR is fixing breakage, it's urgent and may overtake others
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants