Ntuple merger fixes #16073
Merged
Ntuple merger fixes #16073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first part of the parallel tasks code doesn't need to be parallelized, and it can in fact be wrong when run in parallel (specifically, ThrowOnError may not play well with tbb). Also, we now avoid spawning the parallel tasks altogether if we don't need to change the pages compression.
silverweed
force-pushed
the
ntuple_merger_fixes
branch
from
58bc47b
to
96af86f
Compare
Test Results 13 files 13 suites 2d 19h 43m 54s ⏱️ For more details on these failures, see this check. Results for commit 96af86f. |
hahnjo
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Moves some code out of the parallel tasks in RNTupleMerger (particularly,
ThrowOnErrorwhich is not necessarily happily parallelizable).It also avoids spawning the parallel tasks if not needed, i.e. if we don't need to change the compression of the pages.
Checklist: