-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Rd macros if checking package #44
Conversation
I think we need a default value for the > spell_check_files("man/spell_check_files.Rd")
# Error in tools::RdTextFilter(rdfile, macros = macros) :
# argument "macros" is missing, with no default |
By default it loads R's system macros.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 45.11% 44.22% -0.89%
==========================================
Files 7 7
Lines 317 303 -14
==========================================
- Hits 143 134 -9
+ Misses 174 169 -5
Continue to review full report at Codecov.
|
I changed it to use the |
Thanks. Is the I think it's a bit confusing to have undocumented parameters in Looks good otherwise I think. |
I don't think it is essential, but I don't know when |
OK I'll take it out then. It's only used for |
I took it out. |
OK looks good now thanks!! |
Closes #42