Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to new industrial_ci version #323

Open
wants to merge 2 commits into
base: kinetic-devel
Choose a base branch
from
Open

migrate to new industrial_ci version #323

wants to merge 2 commits into from

Conversation

mathias-luedtke
Copy link
Member

@miguelprada miguelprada mentioned this pull request Jul 2, 2019
Merged
@gavanderhoorn gavanderhoorn added the wrid19 World ROS-Industrial Day 2019 label Jul 2, 2019
miguelprada
miguelprada previously approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@miguelprada miguelprada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ipa-mdl!

@miguelprada
Copy link
Member

Just realised you marked this as WIP. Are you expecting to update it and point to master after merging ros-industrial/industrial_ci#361?

@mathias-luedtke
Copy link
Member Author

Are you expecting to update it and point to master after merging ros-industrial/industrial_ci#361?

Yes, this was my intention. Of course, it is up to you to merge it (or not)

@mathias-luedtke mathias-luedtke changed the title [WIP] migrate to new industrial_ci version migrate to new industrial_ci version Aug 18, 2019
@gavanderhoorn
Copy link
Member

@miguelprada: I'm thinking I'm going to be OK with merging this PR. What is your opinion?

One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use. I'm not sure whether that is enough of a problem not to accept the PR though.

@mathias-luedtke
Copy link
Member Author

One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use

The new version uses catkin-tools (as before).
Colcon is optional (for ROS1) .

@gavanderhoorn
Copy link
Member

One reason not to merge it would be that we'd not be running the CI with the build environment users are likely to use

The new version uses catkin-tools (as before).
Colcon is optional (for ROS1) .

Ah, I was unaware of this. Thanks for the clarification.

@gavanderhoorn
Copy link
Member

@miguelprada: 🛎️ ?

@gavanderhoorn gavanderhoorn removed the wrid19 World ROS-Industrial Day 2019 label Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelprada miguelprada miguelprada left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathias-luedtke @miguelprada @gavanderhoorn