Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for Dev Containers #407

Merged
merged 107 commits into from
Apr 26, 2023
Merged

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Mar 27, 2023

Related:

TODO:

  • markdown -> restructuredtext
  • refactor docker build instructions

@ruffsl
Copy link
Member Author

ruffsl commented Mar 27, 2023

@SteveMacenski , here is some documentation on my devcontainer work that we discussed over the previous Nav2 meeting.

@ruffsl ruffsl marked this pull request as ready for review March 28, 2023 17:18
@ruffsl
Copy link
Member Author

ruffsl commented Mar 28, 2023

We can save the restructuredtext for last, and I'll refactor docker build instructions based on feedback of what is written thus far.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this isn't strictly for codespaces? I read through most of it and seems good to me!

The only thing I'd ask is that if you haven't yet, to start with a blank slate and follow only the letter of your instructions in this page to see if you can get a successful result at the end. If not, add the details that might be missing for a novice user. We don't want this page to become a hot spot of tickets asking for support because something was unclear or they got stuck on something obvious to you as an existing user of the capability. I do this for every tutorial I write just to make sure I didn't miss anything important

build_instructions/devcontainers.md Outdated Show resolved Hide resolved
@ruffsl
Copy link
Member Author

ruffsl commented Apr 20, 2023

Current layout:

image

@SteveMacenski
Copy link
Member

It looks like your changes broke the mechanism where artifacts are generated so I can see the output and website files in circleci https://app.circleci.com/pipelines/github/ros-planning/navigation.ros.org/1676/workflows/5e58a602-fac9-421b-993b-abd9d0e0dfaa/jobs/1985/artifacts. The job has no recorded artifacts.

with respect to working_directory in docs_exec
@SteveMacenski SteveMacenski merged commit 41ef588 into ros-navigation:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants