Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtest includes should not emit warnings #1133

Open
stertingen opened this issue Feb 18, 2021 · 0 comments
Open

gtest includes should not emit warnings #1133

stertingen opened this issue Feb 18, 2021 · 0 comments

Comments

@stertingen
Copy link

stertingen commented Feb 18, 2021

When having some compiler warnings enabled, building tests may lead to very verbose compiling. This could be resolved by including the gtest headers as system includes.

The relevant part is here: https://github.com/ros/catkin/blob/noetic-devel/cmake/test/gtest.cmake#L178

The line should be (I think):

  # create the executable, with basic + gtest/gmock build flags
  include_directories(SYSTEM ${${type_upper}_INCLUDE_DIRS})
  link_directories(${${type_upper}_LIBRARY_DIRS})

Lots of warnings are emitted on Melodic, so if this is going to be fixed, I'd love to see a backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant