New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build_type conditions are ignored #1179

Open

v-lopez opened this issue Sep 9, 2022 · 0 comments

Contributor

v-lopez commented Sep 9, 2022

This line https://github.com/ros/catkin/blob/noetic-devel/python/catkin/builder.py#L1007 should probably be calling package.get_build_type() (https://github.com/ros-infrastructure/catkin_pkg/blob/master/src/catkin_pkg/package.py#L150)
.

In my case, I have a ROS1/ROS2 package that has:
<build_type condition="$ROS_VERSION == 2">ament_cmake</build_type>

And catkin_make_isolated fails due to unknown build types.

I can workaround it by adding both build types:

    <build_type condition="$ROS_VERSION == 1">catkin</build_type>
    <build_type condition="$ROS_VERSION == 2">ament_cmake</build_type>

But someone else may encounter this and not be able to workaround it.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment