Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: disable_float_background no longer work with floating code completion in the 4eac261 (latest) commit #124

Closed
tin-pham opened this issue Feb 22, 2023 · 2 comments
Labels

Comments

@tin-pham
Copy link

tin-pham commented Feb 22, 2023

Neovim version (nvim -v)

0.8.3

Terminal

Alacrity

Describe the bug

It work just fine in 845a6ad commit

The dim_nc_background still work, so in right panel it background removed
image

Other floating background work just fine

image

I revert to 845a6ad commit and it work like charm
image

Extra: why color now look worse in 4eac261 commit
image

Back then:
image

Steps To Reproduce

  1. Install latest 4eac261 commit of rose-pine/neovim
  2. Turn on disable_float_background

Expected Behavior

  1. Code completion window background not remove

Repro

No response

@tin-pham tin-pham added the bug label Feb 22, 2023
@tin-pham tin-pham changed the title bug: disable_float_background no longer work with floating code completion after i update some plugins bug: disable_float_background no longer work with floating code completion in the last commit Feb 23, 2023
@tin-pham tin-pham changed the title bug: disable_float_background no longer work with floating code completion in the last commit bug: disable_float_background no longer work with floating code completion in the 4eac261 commit Feb 23, 2023
@tin-pham tin-pham changed the title bug: disable_float_background no longer work with floating code completion in the 4eac261 commit bug: disable_float_background no longer work with floating code completion in the 4eac261 (latest) commit Feb 23, 2023
@mvllow
Copy link
Member

mvllow commented Feb 23, 2023

Thanks for pointing these out. I will take a look at the floats asap but as far as the colours being "worse", please provide the output of :Inspect for the interface keys and I'll revert the change :)

@mvllow
Copy link
Member

mvllow commented Feb 23, 2023

Float should be fixed. Colour discussion can be continued at #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants