Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repro: adding node to <style> clears injected styles #1459

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

billyvg
Copy link
Contributor

@billyvg billyvg commented Apr 24, 2024

Here is a repro of a case where a mutation that adds a node to a <style> (at least I think this is what parentId=-2 is) will clear the previously injected styles. This ends up clearing the noscript css so that the contents of the noscript elements will be displayed in the replay.

Here is a repro of a case where a mutation that adds a node to a `<style>` (at least I think this is what `parentId=-2` is) will clear the injected styles. This ends up clearing the `noscript` css so that the contents of the `noscript` elements will be displayed in the replay.
Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: d47ad20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eoghanmurray
Copy link
Contributor

parentId === -2 means the parent node is ignored in terms of slimDom settings.

There is parentId: -1 in this test case which shouldn't happen I believe (if that is possible we should add a record-time test too)

I haven't tried to recreate yet..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants