Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: benchmarks #1542

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: benchmarks #1542

wants to merge 2 commits into from

Conversation

JonasBa
Copy link
Contributor

@JonasBa JonasBa commented Jul 20, 2024

Fixes the benchmark runs and adds a title so its easier to tell what suite was profiled and make sense of the profiles

Copy link

changeset-bot bot commented Jul 20, 2024

⚠️ No Changeset found

Latest commit: d016c87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JonasBa
Copy link
Contributor Author

JonasBa commented Jul 20, 2024

I dont think this needs a changelog since we dont require a package bump. Happy to open one if needed though

Comment on lines +102 to +109
const code = fs
.readFileSync(path.resolve(__dirname, '../../dist/rrweb.umd.cjs'))
.toString();
await page.setContent(`<html>
<script>
${code.toString()}
</script>
</html>`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for moving this (back) to an inlined script element? This should make the profiles harder to read as the source map references are no longer intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants