Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG : RudderStack requirements.txt prevent projects from using python-dotenv 1.0.0 or later #30

Closed
burgaard opened this issue Mar 11, 2024 · 9 comments · Fixed by #35
Closed
Assignees
Labels
bug Something isn't working

Comments

@burgaard
Copy link

The Python SDK currently restricts python-dotenv to less than version 1.0.0:

python-dotenv>=0.21.0, <1.0.0

However, python-dotenv 1.0.0 was released over a year ago (Feb 23, 2023), and the latest version is 1.0.1.

From python-dotenv's change log https://github.com/theskumar/python-dotenv/blob/main/CHANGELOG.md it seems there should be no issue for RudderStack to remove the upper limit, or bump it to, say, 2.0.0:

python-dotenv>=0.21.0, <2.0.0
@burgaard burgaard added the bug Something isn't working label Mar 11, 2024
@itsdebs
Copy link

itsdebs commented Mar 12, 2024

@burgaard Thanks for reporting. We will be releasing the next version with the fixes.

@Elijas
Copy link

Elijas commented Mar 12, 2024

This needs an urgent hotfix, it's causing dependency issues for so many projects depending on RudderStack SDK, because many projects use python-dotenv>=1.0.0

@Elijas
Copy link

Elijas commented Mar 12, 2024

https://github.com/theskumar/python-dotenv/releases
Note: No breaking changes in v1.0.0, it just was declared "stable"

@josead
Copy link

josead commented Mar 15, 2024

Same issue here, please can someone fix this?

@itsdebs
Copy link

itsdebs commented Mar 28, 2024

We have released v2.1.0 with the fix. Thank you for your inputs

@itsdebs itsdebs closed this as completed Mar 28, 2024
@burgaard
Copy link
Author

@itsdebs I just tried upgrading to rudder-sdk-python 2.1.0, but I still get the same version conflict suggesting the updated requirement.txt didn't make into the package:

ERROR: Cannot install -r requirements.txt (line 89), python-dotenv==1.0.1 and rudder-sdk-python==2.1.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested python-dotenv==1.0.1
    pydantic-settings 2.2.1 depends on python-dotenv>=0.21.0
    rudder-sdk-python 2.1.0 depends on python-dotenv<0.22.0 and >=0.21.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

@itsdebs
Copy link

itsdebs commented Mar 29, 2024

@burgaard thank you for reporting this. Looking into it.

@itsdebs itsdebs reopened this Apr 3, 2024
@slothyrulez
Copy link

slothyrulez commented May 2, 2024

@itsdebs A new version has been released but the lib still requires python-dotenv<0.22.0

I think the setup.py was missing from the fix.

"python-dotenv>=0.21.0,<0.22.0",

@engsmith
Copy link

engsmith commented May 2, 2024

#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
6 participants