Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dotenv version (duplicate) #31

Closed
wants to merge 1 commit into from
Closed

fix: dotenv version (duplicate) #31

wants to merge 1 commit into from

Conversation

Elijas
Copy link

@Elijas Elijas commented Mar 12, 2024

Description of the change

Many projects depend on >1.0.0 which causes dependency issues.

https://github.com/theskumar/python-dotenv/releases
Note: No breaking changes in v1.0.0, it just was declared "stable"

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #30

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Elijas Elijas changed the title HOTFIX HOTFIX: Allow python-dotenv>=1.0.0 Mar 12, 2024
@itsdebs
Copy link

itsdebs commented Mar 20, 2024

Hi @Elijas , you need to update the PR title to conventional commits specific. For eg. fix: update dotenv version.
Since you're trying to merge forked repository, test cases are failing as the environment variables are not available.
Please create a branch in this repo to generate a PR or create an account in Rudderstack and update the following secrets in your repository with the values from Rudderstack dashboard.
TEST_WRITE_KEY
TEST_DATA_PLANE_URL

@saikumarrs
Copy link
Member

As a next step, please sign the CLA using this form.

@Elijas
Copy link
Author

Elijas commented Mar 20, 2024

This PR is a duplicate of #32 so I will close it.

Thank you!

@Elijas Elijas closed this Mar 20, 2024
@Elijas Elijas changed the title HOTFIX: Allow python-dotenv>=1.0.0 fix: dotenv version (duplicate) Mar 20, 2024
@Elijas Elijas deleted the patch-1 branch March 20, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG : RudderStack requirements.txt prevent projects from using python-dotenv 1.0.0 or later
3 participants