Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SpectralClanMgmt plugin #6373

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Update SpectralClanMgmt plugin #6373

wants to merge 44 commits into from

Conversation

rebelego
Copy link
Contributor

No description provided.

@rebelego
Added file for plugin, added third-party dependency to build, and ran…
d79a624 
… gradlew to update the verification-metadata.xml file.
@rebelego
Updated third-party dependencies and metadata.
652d8ab
@rebelego
Modified dependencies
84557d7
@rebelego
Modified dependencies
385cc17
@rebelego
Removed third-party dependency and updated commit hash
05e619c
@rebelego
Update commit hash to get plugin changes
c2cc11a
@rebelego
Merge branch 'master' into spectralclanmgmt
29991cf
@rebelego
Update commit hash
5b6450c
@rebelego
Merge remote-tracking branch 'origin/spectralclanmgmt' into spectralc…
b0414d7 
…lanmgmt
@rebelego
Update commit hash
2b68aad
@rebelego
Update verification-metadata.xml
1dc6898
@rebelego
Update commit hash
691f44d
@rebelego
Update commit hash
d5c3ee0
@rebelego
Update commit hash to get plugin updates
c51a193
@rebelego
Update commit hash
c7c07ab
@rebelego
Update commit hash to pull final additions to plugin
7ccc5b0
@rebelego
Add code to unregister SpectralClanMgmtChatboxPanelManager, SpectralC…
ce274a7 
…lanMgmtChatCommandInputManager and SpectralClanMgmtChatCommandManager from the EventBus at plugin's shutdown.
@rebelego
Add warning to manifest.
9058955
@rebelego
Add explanations as to what data is sent above http requests methods
b9a97d0
@rebelego
Update commit hash to pull plugin's required changes.
8189aa6
@rebelego
Update commit hash
281771b
@rebelego
Update commit hash
13fbb6d
@rebelego
Update commit hash
c06ca82
@rebelego
Update commit hash
c2e241f
@rebelego
Update commit hash
fa2d50b
@rebelego
Update spectralclanmgmt
4626f73
@rebelego
Update commit hash
1d28d92
@rebelego
Update spectralclanmgmt
3bdb5e6
@rebelego
Update spectralclanmgmt
b08470a
@rebelego
Update commit hash
070f366
@runelite-github-app
Copy link

runelite-github-app bot commented Jul 29, 2024 •
edited
Loading

spectralclanmgmt: 854bb6b49bacbbc6fd65d3fbe5e00c6dc11e8641...078f096a3f89912529503de745c048f8cde30de7

iProdigy
iProdigy reviewed Jul 29, 2024
View reviewed changes
plugins/spectralclanmgmt Outdated Show resolved Hide resolved
@rebelego rebelego requested a review from iProdigy July 29, 2024 20:08
@iProdigy
Copy link
Member

why are you calling Executors.newSingleThreadScheduledExecutor() multiple times instead of using the injected executor?

@rebelego
Copy link
Contributor Author

why are you calling Executors.newSingleThreadScheduledExecutor() multiple times instead of using the injected executor?

I forgot to remove those.

@rebelego
Copy link
Contributor Author

rebelego commented Jul 29, 2024 •
edited
Loading

I removed the executor calls that weren't needed.

@rebelego
Copy link
Contributor Author

I had to change one other line in the code due to the QoL update today.

@rebelego rebelego changed the title Minor update to SpectralClanMgmt plugin Update SpectralClanMgmt plugin Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iProdigy iProdigy Awaiting requested review from iProdigy

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
plugin change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebelego @iProdigy