Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel-rustc blog post. #1164

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Nov 3, 2023

This is to publicize the shipping of the parallel front-end in nightly, in rust-lang/rust#117435.

@nnethercote
Copy link
Contributor Author

nnethercote commented Nov 3, 2023

cc @SparrowLii @Kobzol @cjgillot @bjorn3 @Zoxc

This post has three important images that you can't see via GitHub review, so I strongly recommend building and viewing it locally:

git clone https://github.com/nnethercote/blog.rust-lang.org/
cd blog.rust-lang.org
git co parallel-rustc
cargo run

Then follow the printed instructions to view the main blog, then follow the link near the top to the the "Inside Rust" blog, then look at the top post.

I have put 2023-11-10 in as a tentative publication date, but that is definitely subject to change.

I'm happy with the post, I think it explains things nicely. Any and all feedback welcome!

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice write-up! I almost feel like it's a shame to have this nice writeup on the Inside Rust blog, and not the main one xD But people will find it anyway.

posts/inside-rust/2023-11-10-parallel-rustc.md Outdated Show resolved Hide resolved
posts/inside-rust/2023-11-10-parallel-rustc.md Outdated Show resolved Hide resolved
Copy link
Member

@SparrowLii SparrowLii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

posts/inside-rust/2023-11-10-parallel-rustc.md Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

I'm personally in favor of this going on the main blog. I think this is effectively framed as a call to general Rust user audience to test, so it makes sense to put it there.

posts/inside-rust/2023-11-10-parallel-rustc.md Outdated Show resolved Hide resolved
posts/inside-rust/2023-11-10-parallel-rustc.md Outdated Show resolved Hide resolved
posts/inside-rust/2023-11-10-parallel-rustc.md Outdated Show resolved Hide resolved
@nnethercote
Copy link
Contributor Author

Thanks for all the review comments. I have added a new commit that addresses most of them.

I'm personally in favor of this going on the main blog.

I don't have strong opinions either way, but I do notice that the Inside Rust blog has numerous articles with "nightly" in the title while the main blog has none.

@nnethercote
Copy link
Contributor Author

BTW I will do at least one more edit pass this week to tighten up the prose, but I don't expect any content changes.

@nnethercote
Copy link
Contributor Author

I have done my final edit. I think it's ready to got on Nov 10, modulo possibly any remaining changes to the "Feedback" section.

@nnethercote
Copy link
Contributor Author

BTW, I'll be away for the weekend from Friday afternoon onward, Australian time, which is early Friday morning in Europe and Thursday evening in North America. So it might make sense to publish some time today, i.e. in the next 12 hours. That will ensure I'm around for last minute edits, and for the first 20-24 hours of discussion on Reddit, etc. Thoughts?

@nnethercote
Copy link
Contributor Author

Ok, I think this is ready to publish. @Mark-Simulacrum, are you the right person to approve it?

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge if we're ready (looks like still at least one comment thread left)

@Mark-Simulacrum
Copy link
Member

Oh, also the post is one day in the future.

@Mark-Simulacrum
Copy link
Member

I'll try to bump the date this morning and merge.

This post targets a general audience and is asking for testing; we
should invite a broader spectrum of folks to reading it.
@Mark-Simulacrum Mark-Simulacrum merged commit 2241ff2 into rust-lang:master Nov 9, 2023
1 check passed
shows the timeline when building [ripgrep](https://crates.io/crates/ripgrep) on
a machine with 28 virtual cores.

![`cargo build --timings` output when compiling ripgrep](../../../../images/inside-rust/2023-11-10-parallel-rustc/cargo-build-timings.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image links are now to inside-rust and for the wrong date, but at least doesn't break them being displayed on the blog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants