Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Allow user to specify ICEs to run + add two new ones #1415

Merged
merged 5 commits into from
Jun 24, 2023

Conversation

BGR360
Copy link
Contributor

@BGR360 BGR360 commented Sep 12, 2022

Was just going to add the two new ICEs, but some of the existing ICEs take an extraordinary amount of time to run on my machine.

So I just added the ability to optionally filter down to one or more specific ICEs when doing cargo run.

cc rust-lang/rust#101696 for the two new ICEs

Some of the ICEs take an extraordinary amount of time to run on my machine.
So I just added the ability to optionally filter down to one or more specific ICEs.
@Alexendoo
Copy link
Member

Nice thanks, will take a look in a moment

Do you know which ones were taking ages on your machine? We try not to have ones that take an inordinate amount of time

@matthiaskrgr
Copy link
Member

Are they related to save analysis? rust-lang/rust#101505

@BGR360
Copy link
Contributor Author

BGR360 commented Sep 12, 2022

I don't know how to tell which ones were taking long. They only show up as .... in the terminal

@matthiaskrgr
Copy link
Member

Hmm, on my machine a cargo run finishes within 42 seconds.
if we hadn't named all the outputs in the rustdoc tests "out.rs" we could tell what file was being checked via ps -aux :/

@BGR360
Copy link
Contributor Author

BGR360 commented Sep 13, 2022

I'm running on an M1 Pro macbook if that makes any difference 🤷

I'll stick some debug logs in there to figure out which ones are running slow

README.md Outdated
4. Copy the code that causes the ICE into your new file.
5. (optional) Verify it works by running `rustup update nightly`, then `cargo run` to run the tests.
5. (optional) Verify it works by running `rustup update nightly`, then
`cargo run NUMBER` to run your ICE.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the below is clearer:

Suggested change
`cargo run NUMBER` to run your ICE.
`cargo run $ISSUE_NUMBER` to run your ICE.

@JohnTitor
Copy link
Member

LGTM! I think we can merge once the comment above is resolved and 09ccc5c is dropped.

@JohnTitor JohnTitor merged commit bc1f019 into rust-lang:master Jun 24, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants