This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add a few ICEs and move some fixed ones around #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
reviewed
Dec 17, 2020
JohnTitor
reviewed
Dec 17, 2020
fanninpm
commented
Dec 17, 2020
|
@fanninpm Could you update the PR description with the rest of the ICEs that you added? EDIT: Never mind, I didn't notice those were only the fixed ICEs :) |
By my understanding, I wouldn't have permission to do that in that manner. |
JohnTitor
reviewed
Dec 19, 2020
Ah, seems so :/ Almost looks fine, r=me with the above comments are addressed and moving fixed ICEs are dropped. |
Issue: rust-lang/rust#80062
Issue: rust-lang/rust#80060
Locally running `cargo run` and running `rustc` directly produced different results. Call rustc on 78651 directly instead of indirectly (through cargo). Issue: rust-lang/rust#78651
Issue: rust-lang/rust#80077
Issue: rust-lang/rust#79018
Issue: rust-lang/rust#73663
Issue: rust-lang/rust#51388
Issue: rust-lang/rust#52893
Issue: rust-lang/rust#67684
Issue: rust-lang/rust#80125
Issue: rust-lang/rust#80074
Issue: rust-lang/rust#80134
fanninpm
force-pushed
the
add-ices-2020-12-16
branch
from
7f70809
to
4fa1fb0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR (#562) contained a file that broke the CI. This manually fixes that.EDIT: This is no longer necessary thanks to #565.The link to each ICE is in the corresponding commit message.