Remove rustversion dev-dependency #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the MSRV is now 1.60.
When kv_unstable is not enabled.
|
The minimal versions issue should be resolved by updating to proc-macro2 v1.0.60 (specifically in dtolnay/proc-macro2@e31d619). But I think this has to happen in serde_derive? |
Oh both serde_derive and sval_derive define |
|
Ah at first I was reading minimal versions as MSRV and wasn’t following what you meant. Now I get it. I’m happy to add minimal versions to CI in |
|
Alternatively we could add |
I've went with this option as it's the easiest, even though it's a little hacky. |
Done to make the minimal (crate) version CI happy.
|
I’ll run through later and see if I can yank the derive crates out as dependencies altogether. |
renovate bot
added a commit
to ziyadedher/evm-bench
that referenced
this pull request
Aug 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [log](https://github.com/rust-lang/log) | dependencies | patch | `0.4.19` -> `0.4.20` | --- ### Release Notes <details> <summary>rust-lang/log (log)</summary> ### [`v0.4.20`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0420---2023-07-11) [Compare Source](https://github.com/rust-lang/log/compare/0.4.19...0.4.20) - Remove rustversion dev-dependency by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#568 - Remove `local_inner_macros` usage by [@​EFanZh](https://github.com/EFanZh) in [rust-lang/log#570 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ziyadedher/evm-bench). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
github-merge-queue bot
pushed a commit
to knope-dev/knope
that referenced
this pull request
Aug 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [log](https://github.com/rust-lang/log) | dependencies | patch | `0.4.19` -> `0.4.20` | --- ### Release Notes <details> <summary>rust-lang/log (log)</summary> ### [`v0.4.20`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0420---2023-07-11) [Compare Source](https://github.com/rust-lang/log/compare/0.4.19...0.4.20) - Remove rustversion dev-dependency by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#568 - Remove `local_inner_macros` usage by [@​EFanZh](https://github.com/EFanZh) in [rust-lang/log#570 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/knope-dev/knope). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kbudde
pushed a commit
to kbudde/bench-metrics
that referenced
this pull request
Aug 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [log](https://github.com/rust-lang/log) | dependencies | patch | `0.4.19` -> `0.4.20` | --- ### Release Notes <details> <summary>rust-lang/log (log)</summary> ### [`v0.4.20`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0420---2023-07-11) [Compare Source](https://github.com/rust-lang/log/compare/0.4.19...0.4.20) - Remove rustversion dev-dependency by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#568 - Remove `local_inner_macros` usage by [@​EFanZh](https://github.com/EFanZh) in [rust-lang/log#570 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kbudde/bench-metrics). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fdkevin0
pushed a commit
to fdkevin0/fdkevin-cf-bot
that referenced
this pull request
Aug 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [log](https://github.com/rust-lang/log) | dependencies | patch | `0.4.17` -> `0.4.20` | --- ### Release Notes <details> <summary>rust-lang/log (log)</summary> ### [`v0.4.20`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0420---2023-07-11) [Compare Source](https://github.com/rust-lang/log/compare/0.4.19...0.4.20) - Remove rustversion dev-dependency by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#568 - Remove `local_inner_macros` usage by [@​EFanZh](https://github.com/EFanZh) in [rust-lang/log#570 ### [`v0.4.19`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0419---2023-06-10) [Compare Source](https://github.com/rust-lang/log/compare/0.4.18...0.4.19) - Use target_has_atomic instead of the old atomic_cas cfg by [@​GuillaumeGomez](https://github.com/GuillaumeGomez) in [rust-lang/log#555 - Put MSRV into Cargo.toml by [@​est31](https://github.com/est31) in [rust-lang/log#557 ### [`v0.4.18`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0418---2023-05-28) [Compare Source](https://github.com/rust-lang/log/compare/0.4.17...0.4.18) - fix markdown links (again) by [@​hellow554](https://github.com/hellow554) in [rust-lang/log#513 - add cargo doc to workflow by [@​hellow554](https://github.com/hellow554) in [rust-lang/log#515 - Apply Clippy lints by [@​hellow554](https://github.com/hellow554) in [rust-lang/log#516 - Replace ad-hoc eq_ignore_ascii_case with slice::eq_ignore_ascii_case by [@​glandium](https://github.com/glandium) in [rust-lang/log#519 - fix up windows targets by [@​KodrAus](https://github.com/KodrAus) in [rust-lang/log#528 - typo fix by [@​jiangying000](https://github.com/jiangying000) in [rust-lang/log#529 - Remove dependency on cfg_if by [@​EriKWDev](https://github.com/EriKWDev) in [rust-lang/log#536 - GitHub Workflows security hardening by [@​sashashura](https://github.com/sashashura) in [rust-lang/log#538 - Fix build status badge by [@​atouchet](https://github.com/atouchet) in [rust-lang/log#539 - Add call_logger to the documentation by [@​a1ecbr0wn](https://github.com/a1ecbr0wn) in [rust-lang/log#547 - Use stable internals for key-value API by [@​KodrAus](https://github.com/KodrAus) in [rust-lang/log#550 - Change wording of list of implementations by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#553 - Add std-logger to list of implementations by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#554 - Add `set_max_level_racy` and gate `set_max_level` by [@​djkoloski](https://github.com/djkoloski) in [rust-lang/log#544 - \[doc] src/lib.rs : prefix an unused variable with an underscore by [@​OccupyMars2025](https://github.com/OccupyMars2025) in [rust-lang/log#561 - \[doc] src/macros.rs : correct grammar errors of an example in lib documentation by [@​OccupyMars2025](https://github.com/OccupyMars2025) in [rust-lang/log#562 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fdkevin0/fdkevin-cf-bot). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDIuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNi40MC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot
pushed a commit
to X-oss-byte/Nextjs
that referenced
this pull request
Sep 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [log](https://github.com/rust-lang/log) | workspace.dependencies | patch | `0.4.17` -> `0.4.20` | --- ### Release Notes <details> <summary>rust-lang/log (log)</summary> ### [`v0.4.20`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0420---2023-07-11) [Compare Source](https://github.com/rust-lang/log/compare/0.4.19...0.4.20) - Remove rustversion dev-dependency by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#568 - Remove `local_inner_macros` usage by [@​EFanZh](https://github.com/EFanZh) in [rust-lang/log#570 ### [`v0.4.19`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0419---2023-06-10) [Compare Source](https://github.com/rust-lang/log/compare/0.4.18...0.4.19) - Use target_has_atomic instead of the old atomic_cas cfg by [@​GuillaumeGomez](https://github.com/GuillaumeGomez) in [rust-lang/log#555 - Put MSRV into Cargo.toml by [@​est31](https://github.com/est31) in [rust-lang/log#557 ### [`v0.4.18`](https://github.com/rust-lang/log/blob/HEAD/CHANGELOG.md#0418---2023-05-28) [Compare Source](https://github.com/rust-lang/log/compare/0.4.17...0.4.18) - fix markdown links (again) by [@​hellow554](https://github.com/hellow554) in [rust-lang/log#513 - add cargo doc to workflow by [@​hellow554](https://github.com/hellow554) in [rust-lang/log#515 - Apply Clippy lints by [@​hellow554](https://github.com/hellow554) in [rust-lang/log#516 - Replace ad-hoc eq_ignore_ascii_case with slice::eq_ignore_ascii_case by [@​glandium](https://github.com/glandium) in [rust-lang/log#519 - fix up windows targets by [@​KodrAus](https://github.com/KodrAus) in [rust-lang/log#528 - typo fix by [@​jiangying000](https://github.com/jiangying000) in [rust-lang/log#529 - Remove dependency on cfg_if by [@​EriKWDev](https://github.com/EriKWDev) in [rust-lang/log#536 - GitHub Workflows security hardening by [@​sashashura](https://github.com/sashashura) in [rust-lang/log#538 - Fix build status badge by [@​atouchet](https://github.com/atouchet) in [rust-lang/log#539 - Add call_logger to the documentation by [@​a1ecbr0wn](https://github.com/a1ecbr0wn) in [rust-lang/log#547 - Use stable internals for key-value API by [@​KodrAus](https://github.com/KodrAus) in [rust-lang/log#550 - Change wording of list of implementations by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#553 - Add std-logger to list of implementations by [@​Thomasdezeeuw](https://github.com/Thomasdezeeuw) in [rust-lang/log#554 - Add `set_max_level_racy` and gate `set_max_level` by [@​djkoloski](https://github.com/djkoloski) in [rust-lang/log#544 - \[doc] src/lib.rs : prefix an unused variable with an underscore by [@​OccupyMars2025](https://github.com/OccupyMars2025) in [rust-lang/log#561 - \[doc] src/macros.rs : correct grammar errors of an example in lib documentation by [@​OccupyMars2025](https://github.com/OccupyMars2025) in [rust-lang/log#562 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sammyfilly/Nextjs).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the MSRV is now 1.60.