Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looks like it hangs right before printing failures #8

Closed
matthiaskrgr opened this issue May 9, 2022 · 2 comments
Closed

looks like it hangs right before printing failures #8

matthiaskrgr opened this issue May 9, 2022 · 2 comments

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented May 9, 2022

I was running ./run-test.sh core --all-targets with a couple of extra flags

diff --git a/run-test.sh b/run-test.sh
index a6a2841..8d4bc6d 100755
--- a/run-test.sh
+++ b/run-test.sh
@@ -32,6 +32,8 @@ export MIRI_LIB_SRC
 rm -f lib$CRATE
 ln -s "$MIRI_LIB_SRC"/$CRATE lib$CRATE

+export MIRIFLAGS="-Zmiri-check-number-validity -Zmiri-strict-provenance  -Zmiri-symbolic-alignment-check -Zmiri-tag-raw-pointers"
+
 # run test
 cd ./${CRATE}_miri_test
 cargo miri setup

and after printing failures: it looked like the script/test execution was stuck.
No further output was printed, I could watch the miri slowly eat more and more memory and I aborted it after reaching ~9-10 gigs.

perf top showed a lot going on miri::stacked_borrows::Stack, wondering if we hit some kind of loop somehow

  47,29%  miri                                 [.] <miri::stacked_borrows::Stack>::access
 38,71%  miri                                 [.] <miri::stacked_borrows::Stack>::grant
  0,59%  [kernel]                             [k] mem_cgroup_iter

miri 0.1.0 (3b8b6aa 2022-05-06)

@RalfJung
Copy link
Member

RalfJung commented May 9, 2022

This looks like the regular Stacked Borrows super-linear complexity to me. I just wonder what it is computing before printing the failures...

... why are there any failures anyway? Maybe because the symbolic alignment check is not compatible with all of the core tests? That's why we do --skip align on CI for that. Maybe try passing align to only run the failing lists, see if that makes a difference?

@RalfJung
Copy link
Member

RalfJung commented Aug 6, 2022

Closing in favor of rust-lang/miri#2273.

@RalfJung RalfJung closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2022
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 3, 2022
…mulacrum

Update backtrace

Most notably, this pulls in rust-lang/backtrace-rs@ebc9a85, which is both a bugfix and a significant performance improvement for Miri, since fixing the bug makes `RUST_BACKTRACE=1` backtraces much smaller: rust-lang/miri#2273, rust-lang/miri-test-libstd#8

This also pulls in other commits which turn the backtrace-rs CI green. That's nice.
workingjubilee pushed a commit to tcdi/postgrestd that referenced this issue Sep 15, 2022
Update backtrace

Most notably, this pulls in rust-lang/backtrace-rs@ebc9a85, which is both a bugfix and a significant performance improvement for Miri, since fixing the bug makes `RUST_BACKTRACE=1` backtraces much smaller: rust-lang/miri#2273, rust-lang/miri-test-libstd#8

This also pulls in other commits which turn the backtrace-rs CI green. That's nice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants