Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Added Frequently Asked Questions Page #202

Closed
wants to merge 42 commits into from
Closed

Added Frequently Asked Questions Page #202

wants to merge 42 commits into from

Conversation

alilleybrinker
Copy link
Contributor

This commit is the first draft of a new Frequently Asked Questions (FAQ) page for the Rust website. It provides answers for all but 4 of the 130 questions asked by the community, which can be found on the tracking issue #181.

The answers could use some review, as could the design and organization. I've tried to provide clear, concise answers that more often than not point people to the relevant portion of the Rust book.

Thoughts? Changes?

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson
Copy link
Contributor

brson commented Oct 23, 2015

\o/ Woah! So much web site. Thanks.

@Diggsey
Copy link

Diggsey commented Oct 23, 2015

Some thoughts while reading through it:

  • Why does "very small and limited runtime" link to lazy_static?
  • "Can I use globals across threads without unsafe" - You can use them as long as they're Sync and don't implement Drop, you just can't mutate them.
  • "there is no total ordering for floating point numbers" - Technically, the spec does define several possible total orderings for floating point numbers, at least one of which is implemented by an external crate - maybe link to it?
  • "How do I return a borrow to something I created from a function?" - Maybe suggest returning an owning type like String instead, and possibly mention Cow.
  • "How can I define a struct that contains a pointer to one of its own fields?" - I think you can actually do this, but it's useless as the struct becomes permanently borrowed (by itself), and so cannot ever be moved.
  • "What is the difference between consuming and moving/taking ownership?" - They're actually the same thing. When you call a method which consumes self, there's no requirement that self is dropped, it's simply moved into the method.
  • "Using Deref coercions! Strings and Vecs will automatically coerce to their respective slices when referenced" - The term "referenced" is very ambiguous here, maybe make it clear that you mean using &var.
  • "How do I do O(1) character access in a String?" - You can: str implements both Index and IndexMut, and so indexing is available via both String and &str. The caveats you mentioned still apply, but rather than getting out nonsense data, indexing will panic if it's not a valid UTF8 boundary.
  • "The char type is UCS4" - Actually, it's UTF32, which is subtly different because it disallows values outside the range 0-0x10FFFF, or within the range reserved for UTF16 surrogates. This is necessary to ensure that it can only contain valid unicode characters.
  • "Modules and Crates" - Maybe mention that use declarations are always relative to the crate root, rather than the current module, which is different from how name resolution works for everything else. This is one of the most confusing things when first using rust's module system.
  • "What is "monomorphisation" - C++ programmers will know this as template instantiation. In rust however, it's an implementation detail rather than a language feature.
  • "How does Rust's ownership system related to move semantics in C++?" - Maybe note that unlike in rust, in C++ destructors are still called after a value has been moved, ie. it's a destructive copy rather than an actual move.
  • "Does Rust have C++-style constructors?" - Mention that methods which construct value are typically named "new".

@alilleybrinker
Copy link
Contributor Author

Wonderful! This is exactly the input I'm looking for:

Why does "very small and limited runtime" link to lazy_static?

Ah, mistake during editing. Fixing now.

"Can I use globals across threads without unsafe" - You can use them as long as they're Sync and don't implement Drop, you just can't mutate them.

Good to know. I've updated my answer accordingly.

"there is no total ordering for floating point numbers" - Technically, the spec does define several possible total orderings for floating point numbers, at least one of which is implemented by an external crate - maybe link to it?

Do you know which crate?

"How do I return a borrow to something I created from a function?" - Maybe suggest returning an owning type like String instead, and possibly mention Cow.

Good point. Updated.

"How can I define a struct that contains a pointer to one of its own fields?" - I think you can actually do this, but it's useless as the struct becomes permanently borrowed (by itself), and so cannot ever be moved.

Do you have some example code that does this? I'd like to provide an example if I can.

"What is the difference between consuming and moving/taking ownership?" - They're actually the same thing. When you call a method which consumes self, there's no requirement that self is dropped, it's simply moved into the method.

You're right. Fixed.

"Using Deref coercions! Strings and Vecs will automatically coerce to their respective slices when referenced" - The term "referenced" is very ambiguous here, maybe make it clear that you mean using &var.

I agree. I've clarified the language.

"How do I do O(1) character access in a String?" - You can: str implements both Index and IndexMut, and so indexing is available via both String and &str. The caveats you mentioned still apply, but rather than getting out nonsense data, indexing will panic if it's not a valid UTF8 boundary.

Good point. I've updated the answer.

"The char type is UCS4" - Actually, it's UTF32, which is subtly different because it disallows values outside the range 0-0x10FFFF, or within the range reserved for UTF16 surrogates. This is necessary to ensure that it can only contain valid unicode characters.

Yup. I copied this answer verbatim from a much older FAQ on the Rust website. It may have been true at one point (I don't know), but you're right that it isn't now.

"Modules and Crates" - Maybe mention that use declarations are always relative to the crate root, rather than the current module, which is different from how name resolution works for everything else. This is one of the most confusing things when first using rust's module system.

I've added an answer addressing this.

"What is "monomorphisation" - C++ programmers will know this as template instantiation. In rust however, it's an implementation detail rather than a language feature.

Good idea. Added.

"How does Rust's ownership system related to move semantics in C++?" - Maybe note that unlike in rust, in C++ destructors are still called after a value has been moved, ie. it's a destructive copy rather than an actual move.

Yup. Added.

"Does Rust have C++-style constructors?" - Mention that methods which construct value are typically named "new".

Added, along with a small example of such a function.

@alilleybrinker
Copy link
Contributor Author

Before anything gets merged I do want to note that four questions remain unanswered and commented out in the source code. This does not necessarily need to block merging, but if someone can answer any of these questions before we merge that would be much appreciated. If not, then afterward works.

@Diggsey
Copy link

Diggsey commented Oct 23, 2015

Do you know which crate?

https://crates.io/crates/ordered-float

Do you have some example code that does this? I'd like to provide an example if I can.

http://is.gd/MDSXVA

@alilleybrinker
Copy link
Contributor Author

Okay, I've updated it with that information.

@alilleybrinker
Copy link
Contributor Author

I think this is ready to merge, unless there are concerns about the specialized styling for the page.

@brson
Copy link
Contributor

brson commented Nov 5, 2015

@steveklabnik
Copy link
Member

😍


As always, this question is difficult to answer. There's still a lot of work to do on speed, and depending on what you're benchmarking, Rust has variable performance.

That said, it is an explicit goal of Rust to be as fast as C++ for most things. Language decisions are made with performance in mind, and we want Rust to be as fast as possible. Given that Rust is built on top of LLVM, any performance improvements in it also help Rust become faster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"also helps" instead of "also help" I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"C++" -> "idiomatic C++" I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d say “at least as fast”. “as fast as” implies equality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brson why is it important to mention "idiomatic"? Is it because on some benchmarks, people use non-idiomatic C++ to win?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. Pedants can easily write horrible C++ code that beats safe
Rust as a counter-argument to performance claims, so we typically qualify
them with 'idiomatic C++'.

On the other hand though, in many cases safe Rust can trounce even
horribly-unsafe C++, and its our prerogative to make strong claims to sell
Rust (I don't mind ruffling feathers a bit). I'll think about it.

On Wed, Nov 18, 2015 at 4:53 AM, Tshepang Lekhonkhobe <
[email protected]> wrote:

In faq.md
#202 (comment):

  •    <li><a href="#cross-platform">Cross-Platform</a></li>
    
  •    <li><a href="#design-patterns">Design Patterns</a></li>
    
  •    <li><a href="#macros">Macros</a></li>
    
  •    <li><a href="#other-languages">Other Languages</a></li>
    
  •    <li><a href="#licensing">Licensing</a></li>
    
  •    <li><a href="#naming">Naming</a></li>
    

+
+
+## Performance
+
+#### How fast is Rust?
+
+As always, this question is difficult to answer. There's still a lot of work to do on speed, and depending on what you're benchmarking, Rust has variable performance.
+
+That said, it is an explicit goal of Rust to be as fast as C++ for most things. Language decisions are made with performance in mind, and we want Rust to be as fast as possible. Given that Rust is built on top of LLVM, any performance improvements in it also help Rust become faster.

@brson https://github.com/brson why is it important to mention
"idiomatic"? Is it because on some benchmarks, people use non-idiomatic C++
to win?


Reply to this email directly or view it on GitHub
https://github.com/rust-lang/rust-www/pull/202/files#r45194937.

@aturon
Copy link
Member

aturon commented Nov 5, 2015

cc me. We need to advertise this PR very widely, get the whole community's eyes on it.

@edunham
Copy link
Member

edunham commented Nov 5, 2015

Could this be formatted so each question has an anchor, and I can link to a specific section? I imagine needing to link particular questions to new users quite frequently, and it'd be better to include the section in the URL than to tell them "click here and scrolll"

# Frequently Asked Questions

This document exists to answer some common questions about the Rust programming language. It is not a complete guide to the language, nor is it a tool for teaching the language. Rather, it exists as a reference to answer oft-repeated questions people in the Rust community encounter, and to clarify some of the design and history of the language.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This para explains why this page 'exists' twice (first sentence and third). It's not bad but feels like it could be tightened up. No suggestions offhand.

@alilleybrinker
Copy link
Contributor Author

Obviously things aren't quite done yet. I have some more direct feedback to go over, and I need to address @brson's previous points. But I just want to say that this has been a really great process, and I can't wait to get this thing polished and merged. Thanks for all the help and feedback, everyone.

Oh, and no problem @steveklabnik. It's been my pleasure.


Rust `for` loops call `into_iter()` (defined on the `IntoIterator` trait) for whatever they're iterating over. Anything implementing the `IntoIterator` trait may be looped over with a `for` loop. `IntoIterator` is implemented for `&Vec` and `&mut Vec`, causing the iterator from `into_iter()` to borrow the contents of the collection, rather than moving/consuming them. The same is true for other standard collections as well.

If a moving/consuming iterator is desired, write the `for` loop without `&` or `&mut` on the collection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean "without & or &mut in the iteration", right?

(Not "collection", that is)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Thanks. I've fixed it.

@pnkfelix
Copy link
Member

pnkfelix commented Jan 8, 2016

(great job incorporating feedback @AndrewBrinker ; I was especially impressed by the places where I said "oh man this is wrong but I don't know how to fix it" (and I threw up my hands) and you subsequently found a solution, quite quickly!)

@alilleybrinker
Copy link
Contributor Author

Thanks @pnkfelix! I'm glad you like what I've done. It wouldn't have been possible without all the great feedback from everyone. The current version is much much better than my first draft. It'll be interesting to see how the document evolves over time, and to see what sort of feedback we get once it's up on the site.

@brson, I know you have some style changes you'd like made, and that your plan is to wrap this up yourself (I'm guessing squash down all the commits in this PR). Should I incorporate the style changes here, or is that something you'd like to do?

Also, I am still working on your big list of thoughts. The deref coercion and higher-kinded types answers have been updated, but the rest still need to be addressed properly.

@alilleybrinker
Copy link
Contributor Author

Also, I started adding a bunch of missing links to the API docs at @steveklabnik's suggestion, but I'm not finished yet.


### When should I use an implicit return?

Implicit returns are simply a coding style option, and can be used as the final line in a block expression. While early returns require an explicit `return` keyword, any other return can be made implicit according to your preferences or the preferences of your project. In the Rust project itself, the style guidelines lean toward preferring implicit returns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an explanation of Rust's expression-oriented syntax and value flow would be good for this question. Implicit returns follow naturally from the normal evaluation rules, and mentioning only block expressions doesn't tell the whole story since the final expression might be, say, an if expression which new users might not be aware is an expression at all. Maybe we could link to a place in the book that describes this.

On the style guideline side, you could note the benefit of using return only for early returns, so you know normal control and value flow is being interrupted wherever you see it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, implicit returns are not mere style. They are a strong convention.

@tshepang
Copy link
Member

tshepang commented Jan 8, 2016

@AndrewBrinker rocks!


### Can I use static values across threads without an `unsafe` block?

Yes, if the type implements `Sync`, doesn't implement `Drop`, and you don't try to mutate the value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutation is safe if it's synchronized (e.g. Mutex<T> or AtomicUsize in a static is fine). Currently you need something like the lazy_static crate to initialize a Mutex<T> in a static, but AtomicUsize statics can be created and mutated in stable Rust with just libstd.

@solson
Copy link
Member

solson commented Jan 8, 2016

This is shaping up to be quite excellent! Thanks to everyone who's been working so hard on this. 😄

@alilleybrinker
Copy link
Contributor Author

Okay, I've now made changes addressing all but the following points of @brson's:

  • The exceptions answer still needs a rewrite
  • We still don't have an answer on Rust's name (I'm actually not sure what the real explanation is here)
  • The "Concurrency," "Macros," and "Debugging" sections are still small (I think this is fine for now. They will almost certainly grow in future revisions based on community feedback).

I am also still going through the entire document adding links to the API docs.

@alilleybrinker
Copy link
Contributor Author

Okay, I've finished adding the links to the API docs, and I've made the correction suggested by @tsion.

@brson
Copy link
Contributor

brson commented Jan 12, 2016

@brson, I know you have some style changes you'd like made, and that your plan is to wrap this up yourself (I'm guessing squash down all the commits in this PR). Should I incorporate the style changes here, or is that something you'd like to do?

I'll take care of merging the styles. I am going to open one PR that contains all pending website changes.

@brson
Copy link
Contributor

brson commented Jan 12, 2016

My previous points have been addressed to my satisfaction (for the most part, see below), and I'm intending to merge this with the other open PRs and my style changes into one fresh PR for landing.

The only remaining big concerns I have about the FAQ are: HKT section, while better, in the first section makes it sound like Rust has HKT by saying that type constructors that exist are KHTs; there's still no Q&A for 'What does "Rust" mean'.

I'm happy to address those in follow ups though.

@brson
Copy link
Contributor

brson commented Jan 12, 2016

Here's the combined PR.

Thank you everybody for the amazing reviews and @AndrewBrinker for putting it all together. We're almost done.

@brson brson closed this Jan 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.