Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe Transmute RFC #5

Merged
merged 61 commits into from
Aug 31, 2020
Merged

Safe Transmute RFC #5

merged 61 commits into from
Aug 31, 2020
+2,537 −0

Commits on Aug 3, 2020

  1. Create 0000-safe-transmute.md

    @jswrenn
    jswrenn committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    8e0dc26 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    typo fixes from @jonas-schievink

Co-authored-by: Jonas Schievink <[email protected]>
    @jswrenn @jonas-schievink
    jswrenn and jonas-schievink committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    651e3bf View commit details
    Browse the repository at this point in the history

  3. Fix derive expansion.

    @jswrenn
    jswrenn committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    7a88370 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. reword motivation 

    Resolves https://github.com/rust-lang/project-safe-transmute/pull/5/files#r464502312
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    32bc4b9 View commit details
    Browse the repository at this point in the history

  2. Constrained -> NonEmptySlice 

    rust-lang#5 (comment)
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    6ea3705 View commit details
    Browse the repository at this point in the history

  3. missing word 

    rust-lang#5 (comment)
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    5eafe9f View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Kelly -> Kelley
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    3a4e576 View commit details
    Browse the repository at this point in the history

  5. add lifetime parameter to NonEmptySlice 

    rust-lang#5 (comment)
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    00167d6 View commit details
    Browse the repository at this point in the history

  6. TransmuteFrom connotes conversion 

    rust-lang#5 (comment)
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    cf20426 View commit details
    Browse the repository at this point in the history

  7. extra explanatory comments on Summary example 

    rust-lang#5 (comment)
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    a5122b2 View commit details
    Browse the repository at this point in the history

  8. clarify why size expansion is dangerous, but leave the door open to it 

    rust-lang#5 (comment)

It's reasonably* valid to expand size when the bytes of destination type that overhang the source type may be uninitialized; e.g.:
  [MaybeUninit<u8>; 2] to [MaybeUninit<u8>; 4]

I say "reasonably" valid, because the rule of thumb with `mem::transmute_copy` has always been DON'T EXPAND SIZE. But when you frame transmutation as a `union` with two variants:
  union Transmute<Src, Dst> {
      src: Src,
      dst: Dst,
  }
then this interpretation of size-expanding transmutes is plausible.
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    1a119b2 View commit details
    Browse the repository at this point in the history

  9. missing word 

    rust-lang#5 (comment)
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    575eb97 View commit details
    Browse the repository at this point in the history

  10. Fix botched types 

    rust-lang#5 (review)
    @jswrenn
    jswrenn committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    5297ad6 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. platform stability clarification 

    clarify that platform-unstable types are addressed, but not their stability
    @jswrenn
    jswrenn committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    f85600d View commit details
    Browse the repository at this point in the history

  2. neglect::Alignment -> NeglectAlignment

    @jswrenn
    jswrenn committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a47b885 View commit details
    Browse the repository at this point in the history

  3. neglect::Alignment -> NeglectAlignment

    @jswrenn
    jswrenn committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    bc1963f View commit details
    Browse the repository at this point in the history

  4. PromiseTransmutable extension 

    rust-lang#5 (comment)
    @jswrenn
    jswrenn committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    ed172fe View commit details
    Browse the repository at this point in the history

  5. clarify the purpose of "Dissecting Stability" 

    The section describes how user-facing complexity is turned into complexity the type system handles.
    @jswrenn
    jswrenn committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    15fd0e9 View commit details
    Browse the repository at this point in the history

  6. rust -> Rust; rustc -> rustc 

    Co-authored-by: Zach Lute <[email protected]>
    @jswrenn @zachlute
    jswrenn and zachlute committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    4946585 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. fix typo in slice casting extension

    @jswrenn
    jswrenn committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    528df3a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. fix dead links

    @jswrenn
    jswrenn committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    216232e View commit details
    Browse the repository at this point in the history

  2. slice casting revamp 

    For actually using slice casting to build other abstractions, it's useful to have a trait name to refer to in `where` bounds.
    @jswrenn
    jswrenn committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    70f2d9c View commit details
    Browse the repository at this point in the history

  3. packet parsing example

    @jswrenn
    jswrenn committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    5424df4 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. packet parsing tweaks

    @jswrenn
    jswrenn committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    cc01609 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. simplify minimal implementation

    @jswrenn
    jswrenn committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    4fe45b6 View commit details
    Browse the repository at this point in the history

  2. fix broken link

    @jswrenn
    jswrenn committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    b38d1df View commit details
    Browse the repository at this point in the history

  3. nix needless for<'a>

    @jswrenn
    jswrenn committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    ea04744 View commit details
    Browse the repository at this point in the history

  4. slice casting tweaks 

    Pedantic changes that make the slice-casting extension closer to something shippable.
    @jswrenn
    jswrenn committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    0fb4863 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. packet parsing contributions from @joshlf

    @jswrenn
    jswrenn committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    b7fef2d View commit details
    Browse the repository at this point in the history

  2. inline minimal implementation (with minor tweaks)

    @jswrenn
    jswrenn committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    41fa339 View commit details
    Browse the repository at this point in the history

  3. link to packet_formats crate in parsing example

    @jswrenn
    jswrenn committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    3d3a3e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. extension: trait gadgets for querying alignment & size

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b25348c View commit details
    Browse the repository at this point in the history

  2. extension: casting revamp

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b2baf68 View commit details
    Browse the repository at this point in the history

  3. rename: UnsafeTransmuteOptions -> TransmuteOptions

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    781cf1f View commit details
    Browse the repository at this point in the history

  4. dim of variation intro

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    a98df6e View commit details
    Browse the repository at this point in the history

  5. typo

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    1df275e View commit details
    Browse the repository at this point in the history

  6. possibility intros

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    a1362e9 View commit details
    Browse the repository at this point in the history

  7. simplified formulation of constructability is a compiler stability ha… 

    …zard

https://internals.rust-lang.org/t/pre-rfc-safer-transmutation/12926/8
    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    7eadf01 View commit details
    Browse the repository at this point in the history

  8. typo

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    d86731c View commit details
    Browse the repository at this point in the history

  9. fix: uninformative PromiseTransmutableInto::Archetype size trick

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    618c8d5 View commit details
    Browse the repository at this point in the history

  10. remove last dependency on const-generics!

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    98eb167 View commit details
    Browse the repository at this point in the history

  11. nix extra sentence

    @jswrenn
    jswrenn committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    2f85008 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. factor out extensions

    @jswrenn
    jswrenn committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    c4f5d60 View commit details
    Browse the repository at this point in the history

  2. rework motivation; cut case studies

    @jswrenn
    jswrenn committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    1fb9949 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. lingering Type -> Archetype

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    579a7a0 View commit details
    Browse the repository at this point in the history

  2. abusing -> using 

    rust-lang#5 (comment)

Co-authored-by: Florian Gilcher <[email protected]>
    @jswrenn @skade
    jswrenn and skade committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    8295f5b View commit details
    Browse the repository at this point in the history

  3. update minimal impl

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    2eaa505 View commit details
    Browse the repository at this point in the history

  4. transmutation definition

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    9081e53 View commit details
    Browse the repository at this point in the history

  5. union repr

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    099896a View commit details
    Browse the repository at this point in the history

  6. REMOVE Dissecting Stability

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    7fe2146 View commit details
    Browse the repository at this point in the history

  7. REMOVE Uncommon Use-Case: Weak Stability Guarantees

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    ed02a09 View commit details
    Browse the repository at this point in the history

  8. syntax highlighting

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    c0063c4 View commit details
    Browse the repository at this point in the history

  9. rework stability rationale

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    079324e View commit details
    Browse the repository at this point in the history

  10. note on endianness

    @jswrenn
    jswrenn committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    19e629e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. undefined *or* unspecified behavior

    @jswrenn
    jswrenn committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    aadfec7 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. improve stability explanation

    @jswrenn
    jswrenn committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    9ed6b6d View commit details
    Browse the repository at this point in the history

  2. add explanatory note to error message

    @jswrenn
    jswrenn committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    93d8394 View commit details
    Browse the repository at this point in the history

  3. prior art: haskell

    @jswrenn
    jswrenn committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    b150c3f View commit details
    Browse the repository at this point in the history

  4. typo: TransmutableFromArchetype -> TransmutableIntoArchetype

    @jswrenn
    jswrenn committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    9fe396e View commit details
    Browse the repository at this point in the history

  5. change casting section heading

    @jswrenn
    jswrenn committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    61448fb View commit details
    Browse the repository at this point in the history

  6. Move one of Archetype's bounds to where 

    This improves the rendering of rustdoc, and leaves us free to remove that bound if need be without violating stability.
    @jswrenn
    jswrenn committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    3217d4a View commit details
    Browse the repository at this point in the history