fix: panic when using float numbers without dots in chain calls #16770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
roife
changed the title
Veykril
approved these changes
Mar 6, 2024
|
Thanks! |
bors
added a commit
that referenced
this pull request
Mar 6, 2024
fix: panic when using float numbers without dots in chain calls Fix #16278. This PR fixes the panic caused by using floating-point numbers without a dot (such as `1e2`) in chain calls. ------------- Although this syntax is very odd 🤣, r-a should not panic.
|
💔 Test failed - checks-actions |
|
Heh I think we had a fmt test in the rust-analyzer crate before but I lifted it into CI if I am not mistaken so that we get annotations in the PR code. You could also look into setting up a git commit hook for yourself. (I don't like them as they slow down the commit command) |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16278.
This PR fixes the panic caused by using floating-point numbers without a dot (such as
1e2) in chain calls.Although this syntax is very odd 🤣, r-a should not panic.