internal: Be more resilient to bad language item definitions in binop inference #17891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
commented
Aug 14, 2024
| self.write_method_resolution(tgt_expr, func, substs); | ||
| let subst = TyBuilder::subst_for_def(self.db, index_trait, None); | ||
| if subst.remaining() != 2 { | ||
| return self.err_ty(); |
There was a problem hiding this comment.
We modify adj above, not sure if it will cause problems.
And I couldn't find a failing test case for this.
flodiebold
approved these changes
Aug 14, 2024
|
@bors r=flodiebold |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16287
Fixes #16286
There's one more in
write_fn_trait_method_resolution, but I'm not sure if it won't cause further problems ininfer_closures.