-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useless_vec: missing spans if vec is not a fn param #12101
Labels
C-bug
Category: Clippy is not doing the correct thing
I-suggestion-causes-error
Issue: The suggestions provided by this Lint cause an ICE/error when applied
Comments
matthiaskrgr
added
C-bug
Category: Clippy is not doing the correct thing
I-suggestion-causes-error
Issue: The suggestions provided by this Lint cause an ICE/error when applied
labels
Jan 5, 2024
@rustbot claim |
5 tasks
github-merge-queue bot
pushed a commit
to privacy-scaling-explorations/zkevm-circuits
that referenced
this issue
Feb 16, 2024
### Description We've been using the version one year ago. Let's get a new year vibe. ### Issue Link ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Refactor (no updates to logic) ### Contents Major clippy fix - Clippy now detect useless vector. It is a little bit [buggy](rust-lang/rust-clippy#12101), and it sometimes complains without giving the exact line.
bors
added a commit
that referenced
this issue
Feb 24, 2024
fix suggestion error in [`useless_vec`] fixes: #12101 --- changelog: fix suggestion error in [`useless_vec`] r+ `@matthiaskrgr` since they opened the issue?
bors
added a commit
that referenced
this issue
Feb 26, 2024
fix suggestion error in [`useless_vec`] fixes: #12101 --- changelog: fix suggestion error in [`useless_vec`] r+ `@matthiaskrgr` since they opened the issue?
bors
added a commit
that referenced
this issue
Feb 26, 2024
fix suggestion error in [`useless_vec`] fixes: #12101 --- changelog: fix suggestion error in [`useless_vec`] r+ `@matthiaskrgr` since they opened the issue?
bors
added a commit
that referenced
this issue
Feb 26, 2024
fix suggestion error in [`useless_vec`] fixes: #12101 --- changelog: fix suggestion error in [`useless_vec`] r+ `@matthiaskrgr` since they opened the issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: Clippy is not doing the correct thing
I-suggestion-causes-error
Issue: The suggestions provided by this Lint cause an ICE/error when applied
Summary
Clippy does not generate proper diagnostics/spans here which in turn makes rustfix fail...
Reproducer
I tried this code:
I expected to see this happen:
Something pointing inside the vec inside the
&( .. )
Instead, this happened:
clippy completely fails to get proper spans lol
Version
Additional Labels
No response
The text was updated successfully, but these errors were encountered: