use is_inside_const_context
for in_constant
util fn
#10679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10452.
This PR improves the
in_constant
util function to detect more cases of const contexts. Previously this function would not detect cases like expressions in array length position or expression in an inline const blockconst { .. }
.changelog: [
bool_to_int_with_if
]: recognize array length operand as being in a const context and don't suggestusize::from
there