Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint excessive_precision on inf #10952

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 14, 2023

Fixes #9910

changelog: [excessive_precision]: No longer lints overflowing literals

@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 14, 2023
clippy_lints/src/float_literal.rs Outdated Show resolved Hide resolved
clippy_lints/src/float_literal.rs Show resolved Hide resolved
clippy_lints/src/float_literal.rs Outdated Show resolved Hide resolved
tests/ui/excessive_precision.rs Show resolved Hide resolved
@dswij dswij added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 15, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@dswij
Copy link
Member

dswij commented Jun 19, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 19, 2023

📌 Commit a899034 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 19, 2023

⌛ Testing commit a899034 with merge e50bc66...

bors added a commit that referenced this pull request Jun 19, 2023
Don't lint `excessive_precision` on inf

Fixes #9910

changelog: [`excessive_precision`]: No longer lints overflowing literals
@bors
Copy link
Collaborator

bors commented Jun 19, 2023

💔 Test failed - checks-action_test

@Centri3
Copy link
Member Author

Centri3 commented Jun 19, 2023

bors just isn't feeling it 😕

@dswij

@dswij
Copy link
Member

dswij commented Jun 20, 2023

bors just isn't feeling it 😕

@dswij

The classic timeless timed out story 😕

@bors retry

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

⌛ Testing commit a899034 with merge 62972ae...

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 62972ae to master...

@bors bors merged commit 62972ae into rust-lang:master Jun 20, 2023
4 checks passed
@Centri3 Centri3 deleted the excessive_precision branch June 20, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excessive_precision suggest invalid code inf_f32
4 participants