Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add necessary parentheses to manual_unwrap_or_default lint output #12532

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add necessary parentheses to manual_unwrap_or_default lint output #12532

merged 1 commit into from
Mar 22, 2024

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Mar 22, 2024 •
edited by llogiq
Loading

Fix #12531

changelog: [manual_unwrap_or_default]: add parentheses to suggestion when appropriate

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 22, 2024
llogiq
llogiq reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, otherwise this looks good.

clippy_lints/src/manual_unwrap_or_default.rs Outdated Show resolved Hide resolved
@llogiq
Copy link
Contributor

llogiq commented Mar 22, 2024

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 22, 2024

📌 Commit 2ffd133 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 22, 2024

⌛ Testing commit 2ffd133 with merge c7bb200...

@bors
Copy link
Collaborator

bors commented Mar 22, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing c7bb200 to master...

@bors bors merged commit c7bb200 into rust-lang:master Mar 22, 2024
5 checks passed
@samueltardieu samueltardieu deleted the issue-12531 branch September 2, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llogiq llogiq llogiq left review comments

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FP manual_unwrap_or_default
4 participants
@samueltardieu @rustbot @llogiq @bors