Fix bool_to_int_with_if false positive with if let
#9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #9738) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
force-pushed
the
bool-to-int-if-let
branch
from
24066b3
to
c80986e
Compare
xFrednet
reviewed
Oct 29, 2022
|
r? @xFrednet |
Alexendoo
force-pushed
the
bool-to-int-if-let
branch
from
c80986e
to
ad5dfcd
Compare
xFrednet
approved these changes
Oct 29, 2022
|
Looks good to me, thank you! Lord Bors, would you please use your magic powers to merge this PR? |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9706
changelog: FP: [
bool_to_int_with_if]: Now ignoresif letstatements