Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint unnecessary_cast in mixed macro context #9980

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Nov 29, 2022

fixes #9960

Time to start making a dent in this onslaught.

changelog: unnecessary_cast: Don't lint when the identifiers context differs from its binding's context for locals

@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2022

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@xFrednet
Copy link
Member

As always, looks good to me! Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 29, 2022

📌 Commit f44b7aa has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 29, 2022

⌛ Testing commit f44b7aa with merge e9a8b8c...

@xFrednet xFrednet added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 29, 2022
@bors
Copy link
Collaborator

bors commented Nov 29, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing e9a8b8c to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Nov 29, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing e9a8b8c to master...

@bors bors merged commit e9a8b8c into rust-lang:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary_cast type error
4 participants