Skip to content

Commit

Permalink
Rollup merge of #110578 - bvanjoi:fix-issue-110547, r=jackh726
Browse files Browse the repository at this point in the history
fix(error): normalize whitespace during msg_to_buffer

close #110547
  • Loading branch information
matthiaskrgr committed Apr 21, 2023
2 parents 7d04655 + a2f275d commit 637d9dd
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 0 deletions.
1 change: 1 addition & 0 deletions compiler/rustc_errors/src/emitter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,7 @@ impl EmitterWriter {
// see?
for (text, style) in msg.iter() {
let text = self.translate_message(text, args).map_err(Report::new).unwrap();
let text = &normalize_whitespace(&text);
let lines = text.split('\n').collect::<Vec<_>>();
if lines.len() > 1 {
for (i, line) in lines.iter().enumerate() {
Expand Down
7 changes: 7 additions & 0 deletions tests/ui/extenv/issue-110547.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// compile-flags: -C debug-assertions

fn main() {
env!{"\t"}; //~ ERROR not defined at compile time
env!("\t"); //~ ERROR not defined at compile time
env!("\u{2069}"); //~ ERROR not defined at compile time
}
29 changes: 29 additions & 0 deletions tests/ui/extenv/issue-110547.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
error: environment variable ` ` not defined at compile time
--> $DIR/issue-110547.rs:4:5
|
LL | env!{"\t"};
| ^^^^^^^^^^
|
= help: use `std::env::var(" ")` to read the variable at run time
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: environment variable ` ` not defined at compile time
--> $DIR/issue-110547.rs:5:5
|
LL | env!("\t");
| ^^^^^^^^^^
|
= help: use `std::env::var(" ")` to read the variable at run time
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: environment variable `` not defined at compile time
--> $DIR/issue-110547.rs:6:5
|
LL | env!("\u{2069}");
| ^^^^^^^^^^^^^^^^
|
= help: use `std::env::var("")` to read the variable at run time
= note: this error originates in the macro `env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 3 previous errors

0 comments on commit 637d9dd

Please sign in to comment.