wrong exit code after ICE

[matthiaskrgr]

found while checking #116658 with

rustc 1.75.0-nightly (c1691db36 2023-10-11)
binary: rustc
commit-hash: c1691db366c0f2e2341c60377c248ca2d9335076
commit-date: 2023-10-11
host: x86_64-unknown-linux-gnu
release: 1.75.0-nightly
LLVM version: 17.0.2

When you run the snipped above with --edition, rustc panics, but the exit status is 1 as if there was just a normal compiler error, instead of a 101.

This tripped up automatic ice-reduction that relies on a somewhat familiar exit code when the program crashes 😅

[Noratrieb]

rust/compiler/rustc_query_system/src/query/plumbing.rs

Line 355 in ab5c841

QueryResult::Poisoned => FatalError.raise(),

is the problematic line here that turns ICEs into "normal" fatal errors that call exit(1)

though actually at least with the non parallel compiler i'm very surprised that we're ending up in a query in the first place after panicking.

[matthiaskrgr]

It seems that current stable does correctly exit with 101 here...

I bisected the exit code 101 -> exit code 1 change with a crashing file ( #117489 ) and got to

Regression in nightly-2023-08-31
Regression in 59a8294

#115144 cc @Zoxc / @compiler-errors

[apiraino]

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-medium