tidy: check fluent files for style

[Xiretza]

Inspired by #100651 (comment)

There were a lot of line length violations, so I've excepted that lint - I'm not sure if fluent files can be formatted to avoid long lines at all.

[rust-highfive]

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

[davidtwco]

This looks good to me, thanks for the patch!

[davidtwco]

r? @davidtwco

[davidtwco]

Great! Will r=me once CI passes.

[davidtwco]

cc @Mark-Simulacrum for the tidy change

[davidtwco]

@bors r+ rollup

[bors]

📌 Commit fd05fa0 has been approved by davidtwco

It is now in the queue for this repository.

[est31]

I'm not sure this PR is a good idea, at least for non-english fluent files, because those will be edited using a tool (at least according to what @Manishearth said), and that tool might not create ftl files that conform with tidy checks. Even with the submodules/subtrees that rustc uses, a lot of them are exempt from tidy, see the filter_dirs function in lib.rs, partially because the CI of those projects don't enforce tidy either, so it might cause issues with submodule upgrades. Note that my complaint only applies to the non-english fluent files, as it is my understanding that the english ftl files are kinda special as they will be maintained outside of the tool (or idk).

[davidtwco]

I'm not sure this PR is a good idea, at least for non-english fluent files, because those will be edited using a tool (at least according to what @Manishearth said), and that tool might not create ftl files that conform with tidy checks. Even with the submodules/subtrees that rustc uses, a lot of them are exempt from tidy, see the filter_dirs function in lib.rs, partially because the CI of those projects don't enforce tidy either, so it might cause issues with submodule upgrades. Note that my complaint only applies to the non-english fluent files, as it is my understanding that the english ftl files are kinda special as they will be maintained outside of the tool (or idk).

English Fluent will be maintained manually like it is now. We can add whatever exceptions we need for submodules or translations or however we end up handling that, so I think this should be okay.

[matthiaskrgr]

@bors r- files are actually causing errors
#100701 (comment)

[Xiretza]

My plan is to wait until #100651 lands, then rebase this (fixing the new formatting problems) and hope it doesn't race another PR that adds whitespace problems. Sound sensible?

[rustbot]

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

[Xiretza]

@rustbot ready

[davidtwco]

I'll approve this but not for inclusion in rollups just in case it gets mixed in with the other translation PRs that are happening and makes things fail.

@bors r+ rollup=never

[bors]

📌 Commit 2954571 has been approved by davidtwco

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2954571 with merge d0ea1d7...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing d0ea1d7 to master...

[rust-timer]

Finished benchmarking commit (d0ea1d7): comparison url.

Instruction count

• Primary benchmarks: ✅ relevant improvement found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	-1.0%	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	-1.0%	1

Max RSS (memory usage)

Results

• Primary benchmarks: ❌ relevant regressions found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	3.2%	4.0%	2
Regressions ❌ (secondary)	2.1%	3.5%	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	-2.9%	1
All ❌✅ (primary)	3.2%	4.0%	2

Cycles

Results

• Primary benchmarks: ✅ relevant improvement found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.5%	-3.5%	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.5%	-3.5%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³