Assert that HIR nodes are not their own parent.

[cjgillot]

Fixes #101505.
Replaces #101513

r? @petrochenkov @nnethercote

[petrochenkov]

Thanks!
r=me with #101688 (comment) addressed.
@rustbot author

[petrochenkov]

@bors r+

[bors]

📌 Commit 51f4869 has been approved by petrochenkov

It is now in the queue for this repository.

[nnethercote]

Thanks, @cjgillot! #101513 added a test, any chance that could be incorporated into this PR?

[bors]

⌛ Testing commit 51f4869 with merge fa521a4...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing fa521a4 to master...

[rust-timer]

Finished benchmarking commit (fa521a4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-4.9%, -1.9%]	7
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.3%]	2
All ❌✅ (primary)	-2.9%	[-4.9%, -1.9%]	7

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²