Rollup of 13 pull requests #104428

matthiaskrgr · 2022-11-15T00:40:48Z

Successful merges:

Adding Fuchsia compiler testing script, docs #103842 (Adding Fuchsia compiler testing script, docs)
Remove leading newlines from NonZero* doc examples #104354 (Remove leading newlines from NonZero* doc examples)
Update compiler-builtins #104372 (Update compiler-builtins)
rustdoc: remove unused CSS code { opacity: 1 } #104380 (rustdoc: remove unused CSS code { opacity: 1 })
Remove dead NoneError diagnostic handling #104381 (Remove dead NoneError diagnostic handling)
Remove unused symbols and diagnostic items #104383 (Remove unused symbols and diagnostic items)
Deriving cleanups #104391 (Deriving cleanups)
Specify language of code comment to generate document #104403 (Specify language of code comment to generate document)
Fix missing minification for static files #104404 (Fix missing minification for static files)
[llvm-wrapper] adapt for LLVM API change #104413 ([llvm-wrapper] adapt for LLVM API change)
rustdoc: fix corner case in search keyboard commands #104415 (rustdoc: fix corner case in search keyboard commands)
Fix suggest associated call syntax #104422 (Fix suggest associated call syntax)
Add test for #102154 #104426 (Add test for ICE: rustdoc: unable to fulfill trait #102154)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

This was originally a part of rust-lang#100316. However, extracting it to a seperate PR should help with any extra testing that might be needed. Signed-off-by: Ayush Singh <[email protected]>

According to https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/CSS.20cleanup this style was added for declarations that no longer use opacity.

please, please, don't match on `Symbol::as_str`s, every time you do, somewhere in the world another waffle becomes sad...

@RalfJung

Spotted by @RalfJung. This causes no behavioural changes.

Because it's always false.

Because it's always empty.

…ipt, r=tmandry Adding Fuchsia compiler testing script, docs Adding Fuchsia compiler testing script and related docs updates r? `@tmandry` cc. `@djkoloski`

Remove leading newlines from `NonZero*` doc examples Like rust-lang#103045, but for `NonZero*`. `@rustbot` label A-docs

…nTitor Update compiler-builtins This was originally a part of rust-lang#100316. However, extracting it to a seperate PR should help with any extra testing that might be needed. Signed-off-by: Ayush Singh <[email protected]>

…r=GuillaumeGomez rustdoc: remove unused CSS `code { opacity: 1 }` According to https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/CSS.20cleanup this style was added for declarations that no longer use opacity.

Remove dead NoneError diagnostic handling `NoneError` was removed some time ago, so this was dead code.

…em, r=compiler-errors Remove unused symbols and diagnostic items As the title suggests, this removes unused symbols from `sym::` and `#[rustc_diagnostic_item]` annotations that weren't mentioned anywhere. Originally I tried to use grep, to find symbols and item names that are never mentioned via `sym::name`, however this produced a lot of false positives (?), for example clippy matching on `Symbol::as_str` or macros "implicitly" adding `sym::`. I ended up fixing all these false positives (?) by hand, but tbh I'm not sure if it was worth it...

…ackh726 Deriving cleanups Fixing some minor problems `@RalfJung` found in rust-lang#99046. r? `@RalfJung`

Specify language of code comment to generate document Fix `let_underscore_drop` comment https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#example-7

…ation, r=notriddle Fix missing minification for static files It's a fix for rust-lang#101702. The problem was that `Path::ends_with` doesn't do what we thought it does: it checks if the entire item is the last path part, no just if the "path string" ends with the given argument. So instead, I just used the `extension()` method to get the information we want. cc `@jsha` r? `@notriddle` PS: Is it worth it to add a CI test to ensure that the minification was performed on JS and CSS files or not?

[llvm-wrapper] adapt for LLVM API change for llvm/llvm-project@feda983.

matthiaskrgr · 2022-11-15T00:41:34Z

@bors r+ rollup=never p=10

bors · 2022-11-15T00:41:36Z

📌 Commit 7c7cb71 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-11-15T06:43:31Z

⌛ Testing commit 7c7cb71 with merge ca92d90...

bors · 2022-11-15T09:37:58Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing ca92d90 to master...

rust-timer · 2022-11-15T09:41:38Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#104426	75928471220c840422154366d40a6b743a9c58b6
#104422	acea870d79d737ccc839cfa64078b5ef0ac0f561
#104415	ca779c96980f6a26b66fa692fda6dc73e74c1e29
#104413	260aa2eddea12738ffbeb356f434f45a4dfe1428
#104404	d5d26c0b90e16abe95721abdd3af630a23efd02b
#104403	81540cb3cb2663747e277bdbacb552ec69231665
#104391	11b9bf22c1a2e807bdc86d7108799728641773a0
#104383	f209d83b69cb42faf10e62337a36ac62c58834ae
#104381	e5016f71e4ca4c92c85240fe0c5bdc917868a522
#104380	21fc63f1c0a23f895878c98d709aa47fc2e23961
#104372	2e514ac874bbab77b1146d82913f63ce33485ef1
#104354	4e9f69bd8980096ff5d80e10ca7b91b07856f560
#103842	a3611e22a01f02a7a974da31161abffdb69d81ca

previous master: 101e1822c3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-11-15T10:56:18Z

Finished benchmarking commit (ca92d90): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.3%, 3.3%]	14
Regressions ❌ (secondary)	2.1%	[0.3%, 3.3%]	23
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[0.3%, 3.3%]	14

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.5%, 2.1%]	2
Regressions ❌ (secondary)	4.8%	[1.1%, 10.8%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-4.0%, -1.1%]	8
All ❌✅ (primary)	1.3%	[0.5%, 2.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	2.2%	[1.7%, 2.5%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-3.5%, -3.5%]	1
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

nnethercote · 2022-11-16T03:30:28Z

All the regressions are in doc builds. I'm guessing #104404 is the most likely cause.
cc @GuillaumeGomez

@rust-timer build d5d26c0b90e16abe95721abdd3af630a23efd02b

rust-timer · 2022-11-16T06:02:55Z

Finished benchmarking commit (d5d26c0b90e16abe95721abdd3af630a23efd02b): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.4%, 3.2%]	14
Regressions ❌ (secondary)	2.1%	[0.4%, 3.3%]	23
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	1.2%	[0.4%, 3.2%]	14

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.8%, 3.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	2.6%	[2.2%, 3.0%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

nnethercote · 2022-11-16T08:27:40Z

Yep, #104404 is definitely the cause of the regression.

rylev · 2022-11-22T14:14:29Z

Justification for this regression was posted #104404. Effectively this regression is taking us back to the baseline.

@rustbot label: +perf-regression-triaged

andrewpollack and others added 30 commits November 11, 2022 18:44

Adding Fuchsia compiler testing script, docs

e1636b8

remove leading newlines from NonZero* doc examples

ce10ac0

Update compiler-builtins

cd2fb43

This was originally a part of rust-lang#100316. However, extracting it to a seperate PR should help with any extra testing that might be needed. Signed-off-by: Ayush Singh <[email protected]>

Remove unused diagnostic items

409c3ce

Remove unused symbols

4ed2bf6

Remove dead NoneError error handling

25acee5

rustdoc: remove unused CSS code { opacity: 1 }

2575e4d

According to https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/CSS.20cleanup this style was added for declarations that no longer use opacity.

Fix clippy and rustdoc

29fe28f

please, please, don't match on `Symbol::as_str`s, every time you do, somewhere in the world another waffle becomes sad...

Clarify expand_struct_method_body.

9985f46

Spotted by @RalfJung. This causes no behavioural changes.

Remove addr_of argument from create_struct_pattern_fields.

96280b6

Because it's always false.

Remove TraitDef::generics.

111db7d

Because it's always empty.

Specify language of code comment to generate document

a9e4176

Fix missing minification for static files

e6baae5

[llvm-wrapper] adapt for LLVM API change

212ce1f

Drive-by: actual -> rcvr_ty

3f697b8

Move logic into method

bf607da

Do autoderef to match impl against rcvr

5497317

Add regression test

540e12f

rustdoc: fix corner case in search keyboard commands

7b00534

Add test for rust-lang#102154

9214673

Rollup merge of rust-lang#103842 - andrewpollack:add-fuchsia-test-scr…

98be657

…ipt, r=tmandry Adding Fuchsia compiler testing script, docs Adding Fuchsia compiler testing script and related docs updates r? `@tmandry` cc. `@djkoloski`

Rollup merge of rust-lang#104354 - lukas-code:blank-lines-2, r=JohnTitor

1b41a38

Remove leading newlines from `NonZero*` doc examples Like rust-lang#103045, but for `NonZero*`. `@rustbot` label A-docs

Rollup merge of rust-lang#104381 - mejrs:none_error, r=compiler-errors

0a3cb1e

Remove dead NoneError diagnostic handling `NoneError` was removed some time ago, so this was dead code.

Rollup merge of rust-lang#104391 - nnethercote:deriving-cleanups, r=j…

aea4c0c

…ackh726 Deriving cleanups Fixing some minor problems `@RalfJung` found in rust-lang#99046. r? `@RalfJung`

Rollup merge of rust-lang#104403 - koka831:lint-doc, r=Dylan-DPC

da2beab

Specify language of code comment to generate document Fix `let_underscore_drop` comment https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#example-7

Rollup merge of rust-lang#104413 - krasimirgg:llvm-16-mref, r=nikic

f17828d

[llvm-wrapper] adapt for LLVM API change for llvm/llvm-project@feda983.

rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 15, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2022

bors merged commit ca92d90 into rust-lang:master Nov 15, 2022

rustbot added this to the 1.67.0 milestone Nov 15, 2022

bors mentioned this pull request Nov 15, 2022

Move IpAddr, SocketAddr and V4+V6 related types to core #104265

Merged

rustbot added the perf-regression Performance regression. label Nov 15, 2022

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2022

nnethercote mentioned this pull request Nov 16, 2022

Fix missing minification for static files #104404

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 22, 2022

matthiaskrgr deleted the rollup-jo3078i branch December 22, 2022 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 13 pull requests #104428

Rollup of 13 pull requests #104428

matthiaskrgr commented Nov 15, 2022

matthiaskrgr commented Nov 15, 2022

bors commented Nov 15, 2022

bors commented Nov 15, 2022

bors commented Nov 15, 2022

rust-timer commented Nov 15, 2022

rust-timer commented Nov 15, 2022

nnethercote commented Nov 16, 2022

This comment has been minimized.

rust-timer commented Nov 16, 2022

nnethercote commented Nov 16, 2022

rylev commented Nov 22, 2022

Rollup of 13 pull requests #104428

Rollup of 13 pull requests #104428

Conversation

matthiaskrgr commented Nov 15, 2022

matthiaskrgr commented Nov 15, 2022

bors commented Nov 15, 2022

bors commented Nov 15, 2022

bors commented Nov 15, 2022

rust-timer commented Nov 15, 2022

rust-timer commented Nov 15, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

nnethercote commented Nov 16, 2022

This comment has been minimized.

rust-timer commented Nov 16, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

nnethercote commented Nov 16, 2022

rylev commented Nov 22, 2022