Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize before handling simple checks for evaluatability of ty::Const #105400

Merged
merged 1 commit into from
Dec 8, 2022
Merged

normalize before handling simple checks for evaluatability of ty::Const #105400

merged 1 commit into from
Dec 8, 2022

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Dec 6, 2022

{{{{{{{ N }}}}}}} is desugared into a ConstKind::Unevaluated for an anonymous const item so when calling is_const_evaluatable on it we skip the ConstKind::Param(_) => Ok(()) arm which is incorrect.

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2022

Some changes occurred in const_evaluatable.rs

cc @lcnr

@BoxyUwU BoxyUwU added the A-const-generics Area: const generics (parameters and arguments) label Dec 6, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 7, 2022

r? @oli-obk

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 7, 2022

📌 Commit 9f438be has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned petrochenkov Dec 7, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 7, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2022
@bors
Auto merge of rust-lang#105425 - matthiaskrgr:rollup-3ngvxmt, r=matth…
f5418b0 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105267 (Don't ICE in ExprUseVisitor on FRU for non-existent struct)
 - rust-lang#105343 (Simplify attribute handling in rustc_ast_lowering)
 - rust-lang#105368 (Remove more `ref` patterns from the compiler)
 - rust-lang#105400 (normalize before handling simple checks for evaluatability of `ty::Const`)
 - rust-lang#105403 (rustdoc: simplify CSS selectors for item table `.stab`)
 - rust-lang#105418 (fix: remove hack from link.rs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b23419b into rust-lang:master Dec 8, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 8, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-const-generics Area: const generics (parameters and arguments) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@BoxyUwU @rustbot @oli-obk @bors @petrochenkov